Closed Bug 591214 Opened 10 years ago Closed 10 years ago

pilot-notification-popup is transparent on Solaris

Categories

(Mozilla Labs Graveyard :: Test Pilot, defect, P1)

Product:
Mozilla Labs Graveyard
Component:
Test Pilot
Platform:
All
OpenSolaris
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

(Whiteboard: UI, notification, needs-integration)

Attachments

(1 file)

patch
1.43 KB, patch
mossop
: review+
Details | Diff | Splinter Review 
pilot-notification-popup is totally transparent on Solaris, also the close button is invisible.

The problem is chrome.manifest doesn't have a line for SunOS, so we don't have chrome://testpilot-os/skin/feedback.css on Solaris.

Ideally, we should have a fallback skin for unknown os, or chrome.manifest should have a flag for toolkit (e.g. gtk2).

For now, I think we can just add a line for Solaris.
Attached patch patch — — Splinter Review
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #469826 - Flags: review?(jdicarlo)
Hi Ginn,
Thanks for the patch!  Approved and merged into Hg repo in http://hg.mozilla.org/labs/testpilot/rev/2ecd600d2f0e

It's too late to get this in Firefox 4 beta 5 as that just code froze, but it will be in the next one, as well as the next version of Test Pilot to be released on AMO.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Dave, could you please review Ginn's patch for inclusion in Feedback in Firefox 4?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: UI, notification
Whiteboard: UI, notification → UI, notification, needs-integration
Priority: -- → P1
Target Milestone: --- → 1.1
Attachment #469826 - Flags: review?(jdicarlo) → review+
Landed: http://hg.mozilla.org/mozilla-central/rev/08ce5cb2061f
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Product: Mozilla Labs → Mozilla Labs Graveyard
You need to log in before you can comment on or make changes to this bug.