591325 - fix additional chrome style tests which fail when run from a .jar package and minor cleanup

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in bug 574189 the heavy lifting was done for the large majority of tests.  There are a few small test cases that need work or have simple errors that we should fix.

Also from bug 586754 there are some comments that need to be resolved in config/rules.mk.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: additional test cleanup (1.0)

simple patch to cleanup errors and a few tests which need to be fixed while running as a .jar.

Comment 2

[cmtalbert]

Comment on attachment 469860 [details] [diff] [review]
additional test cleanup (1.0)

This looks good.  You verified that the mockObjects.js is self-contained enough to run from simpleTests right?  Cause if it references anything in that original directory it used to be in, that will fail.

r=ctalbert with that addressed.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: additional test cleanup (2.0)

updated with more tests and fixed a bug in the mockObject.js mochitest-plain usage (we needed to add netscape.* permissions to mockObject since it is running in normal mode, not chrome).

try server run is underway

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

ok, an error on windows, I will update here when I have a working patch...should know sometime tomorrow with try server runs and all.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: additional test cleanup (3.0)

latest patch fixes issues with rtlchrome test_bug437844.html on windows with slash direction in javascript and windows.

This passes on try server!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: additional test cleanup (3.1)

ok, this wasn't passing on XPCSHELL tests for the weekend run due to a test that has a hardcoded date in a test file.  So now this depends on bug 594011 in order to land and keep xpcshell green.

This also cleans up some additional browser chrome tests that I had overlooked in running from a .jar.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 472737 [details] [diff] [review]
additional test cleanup (3.1)

feedback+ for rules.mk change.  Looks good.

Comment 8

[cmtalbert]

Comment on attachment 472737 [details] [diff] [review]
additional test cleanup (3.1)

This looks good, I believe it addresses the relativesrcdir regression as well.

Comment 9

[cmtalbert]

http://hg.mozilla.org/mozilla-central/rev/47c6a53ffd8c