59136 - make linux stack trace format addr2line-friendly

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'd like to make the linux stack-trace format generated by
nsTraceRefcnt::WalkTheStack have a little more information so that one can get
line-numbers out of it using addr2line (and possibly post-process the whole
trace with a program that uses addr2line, like leaksoup does).

I'll attach a patch that adds [library_name +offset] to the end of each line in
the stack trace.  You can then use the command `addr2line -C -f -e library_name
+offset` to get the correct function (including statics!) and the line number.
The patch also fixes a printf warning from gcc in UNKNOWN printing that I
introduced a while back, so that nsTraceRefcnt compiles without warnings.

cc:ing folks who I know have some interest in the stack trace format to get
feedback on this change.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: proposed patch

Comment 2

[Chris Waterson]

These changes look fine to me.

Comment 3

[Chris Waterson]

r=waterson

Comment 4

[Brendan Eich [:brendan]]

sr=[e-mail]

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2000-12-02 08:10 -0800.