Closed Bug 591373 Opened 9 years ago Closed 9 years ago

Stop forcing link time code generation in js

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: khuey, Assigned: khuey)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
js forces link time code generation (a remnant from the pre-PGO days).  Now that js is in libxul this adds several minutes to the link time of libxul on a non-PGO opt build.
Attachment #469899 - Flags: review?(ted.mielczarek)
Comment on attachment 469899 [details] [diff] [review]
Patch

As long as sayrer is ok. (This will change the JS perf of non-PGO Windows builds.)
Attachment #469899 - Flags: review?(ted.mielczarek) → review+
yeah, we cool
Approval notes: this will have no impact on our nightly/release Win32 builds, since they're PGO builds, which forces -GL on. This will only impact non-PGO builds, and it should reduce the libxul link time by a fair amount.
And the time to link the js shell and jsapi-tests.  On my machine it wins several minutes.
Assignee: nobody → khuey
Status: NEW → ASSIGNED
Comment on attachment 469899 [details] [diff] [review]
Patch

a=sdwilsh
Attachment #469899 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/16c912714683
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.