591408 - Exiting full screen mode changes icons to small mode and still thinks full screen mode is active

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Dominic]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:2.0b5pre) Gecko/20100827 Minefield/4.0b5pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:2.0b5pre) Gecko/20100827 Minefield/4.0b5pre

Exiting full screen mode changes icons to small mode and still thinks full screen mode is active

Reproducible: Always

Steps to Reproduce:
1. Go into full screen mode (F11)
2. Exit full screen mode (F11)
3. Right click on the "Reload" button
Actual Results:  
The menu says "Exit full screen mode" (even though I am no longer in fulls screen mode), and the large icons have switched to small icons, despite what is set in about:config.

Comment 1

[Dominic]

Attachment: screenshot

Comment 2

[Dominic]

Hitting "Exit Full Screen Mode" actually takes you into full screen and going back into normal mode, from there, has the same problem. 

The only way to fix it is by restarting the browser.

Comment 3

[Jim Mathies [:jimm]]

This should obviously block.

Comment 4

[Dão Gottwald [:dao]]

Is this Windows-only? Seems to work for me on Linux with today's nightly.

Comment 5

[Alice0775 White]

No problem on linux.
Mozilla/5.0 (X11; Linux i686; rv:2.0b5pre) Gecko/20100827 Minefield/4.0b5pre

Comment 6

[Dão Gottwald [:dao]]

I can reproduce on XP.

So I guess this was caused by the widget part of bug 575195, or the appshell part exposed a widget bug or something.

Comment 7

[Jim Mathies [:jimm]]

Attachment: potential fix

We might get multiple fullscreen events, one before we enter, and one after we enter the mode. This fixes the context menu, but there might be other saved "things" here I need to address.

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> We might get multiple fullscreen events

This doesn't sound right.

Comment 9

[Jim Mathies [:jimm]]

(In reply to comment #8)
> (In reply to comment #7)
> > We might get multiple fullscreen events
> 
> This doesn't sound right.

actually looking at widget that doesn't appear to be the case. although clearly showXULChrome is getting called twice.

Comment 10

[Dão Gottwald [:dao]]

(In reply to comment #9)
> actually looking at widget that doesn't appear to be the case. although clearly
> showXULChrome is getting called twice.

It is, and it's kind of bogus too, but this doesn't explain the platform-specific nature of this bug or why it regressed recently:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#3645

Comment 11

[Jim Mathies [:jimm]]

Well, toggle gets called twice with enterFS=true, once before we enter it and once after. It's only called once when exiting.

Comment 12

[Jim Mathies [:jimm]]

So when we go into fullscreen from F11, nsGlobalWindow's SetFullScreen gets called. That fires a dom event to browser.js. Then SetFullScreen calls Makefullscreen on the widget, witch fires a size mode event. That in turn wraps around and enters nsGlobalWindow's SetFullScreen again, triggering a second dom event.

Comment 13

[Jim Mathies [:jimm]]

Attachment: patch

Comment 14

[Jim Mathies [:jimm]]

Comment on attachment 469994 [details] [diff] [review]
patch

bz, this addresses what's happening in comment 12. 

The changes in bug 575195 have widget sending a size mode event when it enters full screen in MakeFullScreen. That ends up back in here and triggers a second dom event, which content doesn't expect. This just filters that second event out if the global window state indicates it is already in full screen mode.

This is currently win specific, although there are open bugs on implementing the same widget behavior on other platforms.

This should also block the latest beta, since the browser ui can get out of sync with the current full screen state.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 469994 [details] [diff] [review]
patch

r=bzbarsky

Comment 16

[Jim Mathies [:jimm]]

Attachment: export

Comment 17

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/rev/0cfd71b0b6a4

Comment 18

[Dominic]

You guys are awesome.