591486 - implement gfx feature blocklist

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: gfxinfo blocklist

This implements a hardcoded blocklist for various gfx features.  The only entry in this list is blocking D2D on known-crashing intel drivers, and the only check so far is for D2D creation.  We'll need to add checks to other places where we want to use gfx features (WebGL, Layers).

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 470045 [details] [diff] [review]
gfxinfo blocklist

Looks good to me. Please separate out the cosmetics changes from the new blacklist stuff though.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/c3ee99044634

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

ugh, forgot to separate out the indentation bits, sorry!

Comment 4

[[e-mail]]

I see this in the checkin bu not the patch for some reason:
>+#ifdef CAIRO_HAS_D2D_SURFACE
>+    PRBool d2dDisabled = PR_FALSE;
>+    PRBool d2dBlocked = PR_FALSE;
>     PRBool safeMode = PR_FALSE;
>-#ifdef CAIRO_HAS_D2D_SURFACE
This breaks building without D2D since safeMode is used outside the ifdef.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

did a merge; I just checked in a followup fix for pulling safeMode out.