Closed Bug 591486 Opened 12 years ago Closed 12 years ago

implement gfx feature blocklist

Categories

(Core :: Graphics, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

References

Details

Attachments

(1 file)

This implements a hardcoded blocklist for various gfx features.  The only entry in this list is blocking D2D on known-crashing intel drivers, and the only check so far is for D2D creation.  We'll need to add checks to other places where we want to use gfx features (WebGL, Layers).
Attachment #470045 - Flags: review?(jmuizelaar)
Comment on attachment 470045 [details] [diff] [review]
gfxinfo blocklist

Looks good to me. Please separate out the cosmetics changes from the new blacklist stuff though.
Attachment #470045 - Flags: review?(jmuizelaar) → review+
Assignee: nobody → vladimir
http://hg.mozilla.org/mozilla-central/rev/c3ee99044634
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
ugh, forgot to separate out the indentation bits, sorry!
I see this in the checkin bu not the patch for some reason:
>+#ifdef CAIRO_HAS_D2D_SURFACE
>+    PRBool d2dDisabled = PR_FALSE;
>+    PRBool d2dBlocked = PR_FALSE;
>     PRBool safeMode = PR_FALSE;
>-#ifdef CAIRO_HAS_D2D_SURFACE
This breaks building without D2D since safeMode is used outside the ifdef.
did a merge; I just checked in a followup fix for pulling safeMode out.
You need to log in before you can comment on or make changes to this bug.