591539 - JM: Remove tracerecursion

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: removed

Much of the tracerecursion complication stemmed from mitigating trace transition costs. It actually swallowed interpreter frames on-trace to avoid leaving the JIT. Integrating this with the method JIT is very tricky. The method JIT is fast enough for now, and will get faster.

Trace-recursion served its purpose and will hopefully be reborn in a world where the tracer stack overlays the mjit/interpreter stack, and JSStackFrames aren't hugeonormous. For now, it's a lot of code that is very difficult to maintain. RIP.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: v2

Remove more remnants, JSOP_TRACE after CALL (requires fixing a lot of debug tests that hardcode bytecode offsets) and some EnterFrame cruft.

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 470118 [details] [diff] [review]
v2

It was an impressive accomplishment while it lasted, but bless JM for letting this stuff go.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

http://hg.mozilla.org/projects/jaegermonkey/rev/e0487d27eb6c