Closed
Bug 591572
Opened 15 years ago
Closed 15 years ago
builder configuration parameter
Categories
(Other Applications Graveyard :: Narcissus, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dherman, Assigned: dherman)
Details
Attachments
(1 file)
|
7.27 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
Make the builder (or actually, a thunk that produces a builder) a global configuration parameter. Set it to DefaultBuilder by default. Add an njs command-line parameter to switch to the SSA builder.
Dave
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #470478 -
Flags: review?(shu)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 470478 [details] [diff] [review]
adds -S/--ssa parameter to switch to SSA builder
Looks good. I like the closing over of builderType in the module pattern. r=me
An aside: should we be using something like Object.create for reflected objects in jsexec like Array to set the correct prototype? Currently they have all the properties of a Function.
Attachment #470478 -
Flags: review?(shu) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•15 years ago
|
||
> An aside: should we be using something like Object.create for reflected objects
> in jsexec like Array to set the correct prototype? Currently they have all the
> properties of a Function.
File a bug, and maybe give a code example? I'm not quite sure what you mean.
Thanks,
Dave
|
|
||
Comment 5•15 years ago
|
||
Submitted as https://bugzilla.mozilla.org/show_bug.cgi?id=592188
|
||
Updated•7 years ago
|
Product: Other Applications → Other Applications Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•