Closed Bug 591572 Opened 11 years ago Closed 11 years ago

builder configuration parameter

Categories

(Other Applications Graveyard :: Narcissus, defect)

Product:
Other Applications Graveyard
Component:
Narcissus
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dherman, Assigned: dherman)

Details

Attachments

(1 file)

adds -S/--ssa parameter to switch to SSA builder
7.27 KB, patch
shu
: review+
Details | Diff | Splinter Review 
Make the builder (or actually, a thunk that produces a builder) a global configuration parameter. Set it to DefaultBuilder by default. Add an njs command-line parameter to switch to the SSA builder.

Dave
Comment on attachment 470478 [details] [diff] [review]
adds -S/--ssa parameter to switch to SSA builder

Looks good. I like the closing over of builderType in the module pattern. r=me

An aside: should we be using something like Object.create for reflected objects in jsexec like Array to set the correct prototype? Currently they have all the properties of a Function.
Attachment #470478 - Flags: review?(shu) → review+
http://hg.mozilla.org/tracemonkey/rev/e8ee411dca70
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
> An aside: should we be using something like Object.create for reflected objects
> in jsexec like Array to set the correct prototype? Currently they have all the
> properties of a Function.

File a bug, and maybe give a code example? I'm not quite sure what you mean.

Thanks,
Dave
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.