Closed
Bug 591575
Opened 14 years ago
Closed 14 years ago
JM: Fix Android build bustage due to "thumb conditional instruction not in IT block"
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file)
999 bytes,
patch
|
sayrer
:
review+
jbramley
:
review+
|
Details | Diff | Splinter Review |
Apparently the IT instruction should be generated automatically but the version of gcc that comes with the latest android NDK doesn't have it. (gcc 4.4.0 which was released before this patch http://sourceware.org/ml/binutils/2009-05/msg00109.html showed up) The assembler also complains about MethodJIT.s:286: Warning: Failed to find real start of function: JaegerTrampoline Not sure if that's bad or not, though I was able to (probably incorrectly) silence it with .thumb_func.
Attachment #470162 -
Flags: review?(Jacob.Bramley)
Updated•14 years ago
|
Attachment #470162 -
Flags: review?(Jacob.Bramley) → review+
Comment 1•14 years ago
|
||
Comment on attachment 470162 [details] [diff] [review] Add IT Marking r+ to fix the build. Jacob should follow up to make sure this is right. AIUI, newer GCC versions generate the 'it' instruction by default.
Attachment #470162 -
Flags: review?(Jacob.Bramley)
Assignee | ||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/projects/jaegermonkey/rev/b4703950e818
Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
Comment on attachment 470162 [details] [diff] [review] Add IT Yep, that's perfect.
Attachment #470162 -
Flags: review?(Jacob.Bramley) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•