591575 - JM: Fix Android build bustage due to "thumb conditional instruction not in IT block"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Michael Wu [:mwu]]

Attachment: Add IT

Apparently the IT instruction should be generated automatically but the version of gcc that comes with the latest android NDK doesn't have it. (gcc 4.4.0 which was released before this patch http://sourceware.org/ml/binutils/2009-05/msg00109.html showed up)

The assembler also complains about
MethodJIT.s:286: Warning: Failed to find real start of function: JaegerTrampoline

Not sure if that's bad or not, though I was able to (probably incorrectly) silence it with .thumb_func.

Comment 1

[Robert Sayre]

Comment on attachment 470162 [details] [diff] [review]
Add IT

Marking r+ to fix the build. Jacob should follow up to make sure this is right. AIUI, newer GCC versions generate the 'it' instruction by default.

Comment 2

[Michael Wu [:mwu]]

http://hg.mozilla.org/projects/jaegermonkey/rev/b4703950e818

Comment 3

[Jacob Bramley [:jbramley]]

Comment on attachment 470162 [details] [diff] [review]
Add IT

Yep, that's perfect.