Closed Bug 591589 Opened 9 years ago Closed 9 years ago

make nbsp an identifier character

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
At the CSS working group meeting earlier this week, the working group resolved the inconsistency between the grammar and the prose regarding which characters could be in and start an identifier by compromising between the two.  We previously followed the prose; other browsers previously followed the grammar.

This means we need to change non-breaking space (NBSP) into an ident-start character.

See http://wiki.csswg.org/spec/css2.1#issue-196
Attachment #470171 - Flags: review?(bzbarsky)
Comment on attachment 470171 [details] [diff] [review]
patch

Looks fine, but can't you start the invalid identifier range with 0x7B in the test?
Attachment #470171 - Flags: review?(bzbarsky) → review+
(In reply to comment #1)
> Looks fine, but can't you start the invalid identifier range with 0x7B in the
> test?

Sure.  I have it changed locally.
http://hg.mozilla.org/mozilla-central/rev/95496fb65889
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.