nsPluginFile::FreePluginInfo doesn't free arrays

VERIFIED FIXED in mozilla0.9

Status

()

Core
Plug-ins
P3
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({mlk})

Trunk
mozilla0.9
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
nsPluginFile::FreePluginInfo doesn't free the actual arrays in the info struct. 
Fix coming shortly.
(Assignee)

Updated

17 years ago
Keywords: mlk
Target Milestone: --- → mozilla0.9
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

17 years ago
Created attachment 18742 [details] [diff] [review]
proposed patch

Comment 2

17 years ago
Right thing to do. r=av
Can info.fVariantCount be zero, yet some (depends on the OS) malloc'ations still 
have been made by the zero-sized calls to PR_Malloc?  I think the best condition 
to test is whether we went thru the PR_Malloc'ating code, which is not the same 
as asking whether fVariantCount is non-zero.

/be
(Assignee)

Comment 4

17 years ago
Created attachment 18849 [details] [diff] [review]
revised patch
Ok, sr=brendan@mozilla.org.

av: nsPluginFile:GetPluginInfo fails to check for malloc failure, and will crash
hard on null pointers if malloc does fail.  How about a patch?

/be
(Assignee)

Comment 6

17 years ago
Fix for leak checked in 2000-11-07 19:10 PDT.
(Assignee)

Comment 7

17 years ago
Filed issue brendan mentioned as bug 59796.  Marking bug fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
verified fix is in. 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.