Closed
Bug 591626
Opened 14 years ago
Closed 14 years ago
:-moz-placeholder is now implemented, uncomment corresponding theme code
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla2.0b7
People
(Reporter: KWierso, Assigned: KWierso)
Details
Attachments
(1 file, 1 obsolete file)
2.73 KB,
patch
|
dao
:
review+
mossop
:
approval2.0+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.8) Gecko/20100723 Ubuntu/10.04 (lucid) Firefox/3.6.8 Build Identifier: Bug 428299 added a block of code commented out in /browser/themes/winstripe/browser/browser-aero.css due to the fact that :-moz-placeholder was not implemented at that time (bug 457801). Bug 457801 landed recently, this block of code should be uncommented. Reproducible: Always
Assignee | ||
Comment 1•14 years ago
|
||
Comment 2•14 years ago
|
||
There's actually more: http://mxr.mozilla.org/mozilla-central/search?string=moz-placeholder&find=themes&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Assignee | ||
Comment 3•14 years ago
|
||
Uncomments everything. A bunch of the files listed in Dao's search are already uncommented, so I left them alone. I uncommented all of the instances that I found regarding :-moz-placeholder. /toolkit/themes/winstripe/global/textbox-aero.css says to uncomment the corresponding code in /layout/reftests/editor/xul/input.css, and there's only one thing in that file that was commented out, so this patch uncomments that.
Attachment #470183 -
Attachment is obsolete: true
Attachment #470226 -
Flags: review?(dao)
Comment 4•14 years ago
|
||
Comment on attachment 470226 [details] [diff] [review] v2 Looks good, thanks!
Attachment #470226 -
Flags: review?(dao)
Attachment #470226 -
Flags: review+
Attachment #470226 -
Flags: approval2.0?
Updated•14 years ago
|
Assignee: nobody → kwierso
Severity: minor → normal
Status: UNCONFIRMED → ASSIGNED
Component: Theme → Themes
Ever confirmed: true
OS: Windows 7 → All
Product: Firefox → Toolkit
QA Contact: theme → themes
Hardware: x86 → All
Summary: :-moz-placeholder is now implemented, uncomment lines 74-79 in browser-aero.css → :-moz-placeholder is now implemented, uncomment corresponding theme code
Updated•14 years ago
|
Version: unspecified → Trunk
Comment 5•14 years ago
|
||
Comment on attachment 470226 [details] [diff] [review] v2 Approved for landing early in the b6 cycle
Attachment #470226 -
Flags: approval2.0? → approval2.0+
Updated•14 years ago
|
Keywords: checkin-needed
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/55f521e7639b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
You need to log in
before you can comment on or make changes to this bug.
Description
•