591697 - Tapping urlbar to show keyboard should not de-select text

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

1. Tap the address bar.  Text is selected, but on-screen keyboard is hidden.
2. Tap the address bar again.

Actual results:  On-screen keyboard appears, but text is de-selected.

Expected results:  Can we change this so that the text is still selected when the on-screen keyboard appears?  (Ideally we could detect if a hardware keyboard is present, and behave differently in that case.)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Before fixing those, we should be sure we want to keep the "double tap" to open the virtual keyboard feature.

Comment 2

[Madhava Enros [:madhava]]

The text should be selected when the user brings up the keyboard (i.e. when he or she can type).  Users overwhelming type new urls or search terms vs. editing existing urls.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.1

The patch keeps the text selected when doing a second touch and correct some others focus bugs on the urlbar:
 * The one mentioned by mbrubeck about the fact that you need 3 taps in landscape mode to show the VKB
 * The fact that the typed text disappears when you try to tap somewhere on the urlbar

Everything went fine on Desktop but I need to check on device (once my build is finished)

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Sadly it does not behave as I want on device :(

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This will be fixed by the patch in bug 596614

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Was this fixed by bug 596614?

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

> Was this fixed by bug 596614?

Matt, can you confirm the awesome bar selection works the way you want now?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 473555 [details] [diff] [review]
Patch v0.1

obsoleting patch since this was fixed by a different bug

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

fixed by bug 596614

Comment 10

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Android; Linux armv71; rv:2.0b8pre) Gecko/20101014 Namoroka/4.0b8pre Fennec/4.0b2pre