Closed Bug 591714 Opened 9 years ago Closed 9 years ago

Remove ancient heapdump code

Categories

(Core :: Widget: Win32, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch rmSplinter Review
If you could actually do anything with tools/footprint/makefile.win (it includes config/rules.mak, so it's been unusable since 2004), it would build you a heapdump.exe, which would grovel through all windows of all running apps, looking for Netscape 6.3 and the Mozilla Application Suite, and send them a message telling them to dump the heap to C:\heapdump.txt (which they would have done, since that was long prior to the code being ifdeffed out), which you could then process with heapdump.pl.

This turns out not to be something that anyone wants to do.
Attachment #470237 - Flags: review?(jmathies)
Comment on attachment 470237 [details] [diff] [review]
rm

I am not a suitable reviewer for the tools portion (and I don't think Jim is either) but dbaron appears to be the owner. r+ for the widget stuff (yay removing more dead code!).
Attachment #470237 - Flags: review?(jmathies)
Attachment #470237 - Flags: review?(dbaron)
Attachment #470237 - Flags: review+
Comment on attachment 470237 [details] [diff] [review]
rm

r=dbaron, though the bit in widget/src/windows/ actually looks somewhat useful; I wonder if we have all that data hooked up to about:memory

If we don't, it might be worth filing a bug with a pointer to that code.
Attachment #470237 - Flags: review?(dbaron) → review+
We don't, but it won't give all that useful data -- since we use jemalloc, we don't go through the windows heap at all.  I suppose someone could be making explicit heap calls (maybe win32 internal code), but for that we should just add an about:memory display for total windows heap size so that we can keep an eye on it.  Whenever I've looked before though, it's never been over 1MB.
http://hg.mozilla.org/mozilla-central/rev/b399dda7375c
Blocks: 512497
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
You need to log in before you can comment on or make changes to this bug.