591715 - Utils.log: add option to use dump instead of console and add timing info

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Michael Yoshitaka Erlewine [:mitcho]]

This is a request to (by default) use dump instead of the console and add an option to print timing information. Both of these, I believe, can make our logging tools more reliable and more helpful.

Comment 1

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Proposed patch

Comment 2

[Ian Gilman [:iangilman]]

Comment on attachment 470238 [details] [diff] [review]
Proposed patch

Forgive my ignorance, but what's the difference between dump and console?

Comment 3

[Ian Gilman [:iangilman]]

Comment on attachment 470238 [details] [diff] [review]
Proposed patch

Okay, Mardak has filled me in (dump goes to the terminal).  I'm game to give it a try; probably fix some of my complaints with the console!

Comment 4

[Dão Gottwald [:dao]]

I think you very much want errors in the error console, so that normal users and testers can see and report them. log could use dump indeed, except that the method probably shouldn't do anything at all in non-debug builds.

Comment 5

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch v2: now uses console by default, but enables dump output

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

Comment 7

[cmtalbert]

Landed http://hg.mozilla.org/mozilla-central/rev/03c90de681a6