Closed Bug 591715 Opened 9 years ago Closed 9 years ago

Utils.log: add option to use dump instead of console and add timing info

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mitcho, Assigned: mitcho)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 2 obsolete files)

This is a request to (by default) use dump instead of the console and add an option to print timing information. Both of these, I believe, can make our logging tools more reliable and more helpful.
Attached patch Proposed patch (obsolete) — Splinter Review
Attachment #470238 - Flags: feedback?(ian)
Comment on attachment 470238 [details] [diff] [review]
Proposed patch

Forgive my ignorance, but what's the difference between dump and console?
Comment on attachment 470238 [details] [diff] [review]
Proposed patch

Okay, Mardak has filled me in (dump goes to the terminal).  I'm game to give it a try; probably fix some of my complaints with the console!
Attachment #470238 - Flags: review?(dolske)
Attachment #470238 - Flags: feedback?(ian)
Attachment #470238 - Flags: feedback+
I think you very much want errors in the error console, so that normal users and testers can see and report them. log could use dump indeed, except that the method probably shouldn't do anything at all in non-debug builds.
Attachment #470238 - Attachment is obsolete: true
Attachment #470951 - Flags: review?(dao)
Attachment #470238 - Flags: review?(dolske)
Summary: Utils.log: use dump instead of console and add timing info → Utils.log: add option to use dump instead of console and add timing info
Attachment #470951 - Flags: review?(dao) → review+
Attachment #470951 - Flags: approval2.0?
Attachment #470951 - Flags: approval2.0? → approval2.0+
Attachment #470951 - Attachment is obsolete: true
Landed http://hg.mozilla.org/mozilla-central/rev/03c90de681a6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.