Open Bug 591787 Opened 10 years ago Updated 9 years ago

[gfxInfo] Unknown adapter RAM for some graphic cards

Categories

(Core :: Graphics, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

ASSIGNED
Tracking Status
blocking2.0 --- -
status2.0 --- ?

People

(Reporter: scoobidiver, Assigned: jrmuizel)

References

Details

(Whiteboard: [patchlove][has draft patch])

Attachments

(4 files)

Build : Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b5pre) Gecko/20100829 Firefox/4.0b5pre

The new graphic section of about:support display Unknown to Adapter RAM for my graphic card Intel GMA 4500M.
This graphic card is particular because it has 2 PNP device ID : the first one is for my LCD, may be the second one is for HDMI.
Attached image Display info screenshot
WinXP version of similar problem - dupe if you want.  Bug 594976.
The memory size of the graphic driver is stored in REG_BINARY key as ULONG in MB:
http://msdn.microsoft.com/en-us/library/ff569670%28VS.85%29.aspx
getKeyValue function can not recognize REG_BINARY key.

I don't think GPU manufacturer uses it correctly, because for me, its value is 0x68c771, that means I have 6.5TB of video memory and not 1.6GB.
Summary: [gfxInfo] Unknown adapter RAM for Intel GMA graphic card → [gfxInfo] Unknown adapter RAM for some graphic cards
Does Grafx Bot's System Info report memory correctly?  Seems to show a sensible number for me.
Wrt bug 595471 comment 8,
Grafx Bot reports:
{
System Information

Display Vendor: NVIDIA (0x10DE)
Display Adapter: NVIDIA GeForce 7300 GT
Display Chipset: 0x0393
Display RAM: 256 MB
Display Drivers: nv4_disp
Driver Version: 6.14.10.9424, 4-19-2007
Display Settings: 1152 x 864 x 32
}
so it really is Firefox which fails to retrieve memory size.
I see that this is set to Win7 in the platform, but I'm seeing the same under Windows 2003:

Adapter Description: Mobile Intel(R) 945 Express Chipset Family
Vendor ID: 8086
Device ID: 27a2
Adapter RAM: Unknown
Adapter Drivers: igxprd32
Driver Version: 6.14.10.4926
Driver Date: 2-15-2008
Direct2D Enabled: false
DirectWrite Enabled: false
GPU Accelerated Windows: 0/1

Grafx Bot shows:

videocard: Intel(R) Soldiers sans frontiers Alpha 1 (VEN_0x8086&DEV_0x27A2)
os: Windows XP 64-bit

Drive date and version number are correct there also.

Also, any idea why the GPU Accelerated Windows would still be effectively disabled? Since the check-in of https://bugzilla.mozilla.org/show_bug.cgi?id=594976 and https://bugzilla.mozilla.org/show_bug.cgi?id=595364 I'd have thought that my system would've met the requirements for at least the accelerated layers? Or is this disabled completely for some reason in 2003? Seems it would be the same as XP?
Tim,
D2D/DW is disabled on Windows 2000/XP/2003 (NT 5.x) whatever the graphic card because Direct2D and DirectWrite don't exist in these OS.
For your case, D3D is also disabled. I assume your graphic card does not meet the minimal HW requirement (graphic driver version is not used for that).

I am not sure that it blocks bug 593678 and bug 595471, because according to my reading of the code, AdapterRAM is only used for "about:support" page and crash reports.
blocking2.0: --- → ?
(In reply to comment #7)
> I assume your graphic card does not meet
> the minimal HW requirement (graphic driver version is not used for that).
Device ID 0x27a2 is listed in GfxInfo.cpp.
http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/GfxInfo.cpp#408
However D3D is disabled on Win2k3 because there are no entries for Win2k3.
http://mxr.mozilla.org/mozilla-central/source/widget/src/windows/GfxInfo.cpp#505
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.h#219
Probably we need to add entries for Win2k3. Should I file a new bug?
> Device ID 0x27a2 is listed in GfxInfo.cpp.
It is only used to block or not D2D/DW features for Win Vista/7 according to the graphic driver version.
D2D/DW is blocked for Win 5.x OSs in :
http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxWindowsPlatform.cpp#313

> Probably we need to add entries for Win2k3. Should I file a new bug?
Intel graphic driver filtering for D2D on Win XP is useless in GfxInfo.cpp as it is blocked in an other part of the code.
We keep it for some could-be graphic issues with D3D.
Moreover, Intel does not provide Win2k3 driver in their support site.
(In reply to comment #9)
> > Device ID 0x27a2 is listed in GfxInfo.cpp.
> It is only used to block or not D2D/DW features for Win Vista/7 according to
> the graphic driver version.
Actually it is also used for D3D9 layers.
http://mxr.mozilla.org/mozilla-central/source/gfx/layers/d3d9/LayerManagerD3D9.cpp#72

> > Probably we need to add entries for Win2k3. Should I file a new bug?
> Intel graphic driver filtering for D2D on Win XP is useless in GfxInfo.cpp as
> it is blocked in an other part of the code.
I don't talk about D2D/DWrite. You said *D3D* is also disabled regardless to the driver version in comment #7, but it is untrue.
>> For your case, D3D is also disabled. I assume your graphic card does not meet
>> the minimal HW requirement (graphic driver version is not used for that).

> Moreover, Intel does not provide Win2k3 driver in their support site.
Intel provides drivers for WinXP x64 which is identified as Win2k3.
Kimura,
The discussion from comment 8 to comment 11 is out of subject.
Feel free to file a new bug about any D3D9 issue you have.
Attached patch Likely fixSplinter Review
I suspect this patch will fix the problem.
I might approve a fix for this, but it doesn't block.
blocking2.0: ? → -
Last time I will mention anything, but if interested, I've opened https://bugzilla.mozilla.org/show_bug.cgi?id=600625 as a D3D Layers on Win2K3 request. Thanks.
Can those with the problem try out the tryserver build and let me know if it fixes it.
Confirm the correct amount shown with try-server build (matches the same value as shown in CPU-Z).
With the try build in comment 14, it is fixed.
"AdapterRAM : 1820" is the same as in grafx bot.
In my case, it shows 128MB, which I guess is the max for my GM965, GPU-Z reports 8MB. I don't know if this is wrong, or just showing different information
No longer blocks: 593678, 595471
(In reply to comment #14)
> And tryserver builds will appear here:

I wanted to check my case (from bug 595471), but the Try build is not available anymore.

Yet, from previous comments, the patch seems fine.
Jeff, is there a schedule for the landing of the patch?
(In reply to comment #22)
> Jeff, is there a schedule for the landing of the patch?

Maybe this week. We don't use display RAM for anything right now so I'm not in a huge rush.
We also can't land this until beta 7 branches.
Now beta 7 branches are released, is it possible to land this patch?
Assignee: nobody → jmuizelaar
Status: NEW → ASSIGNED
status2.0: --- → ?
Whiteboard: [patchlove]
Whiteboard: [patchlove] → [patchlove][has draft patch]
Duplicate of this bug: 693026
Attachment #479374 - Flags: review?(ehsan)
Comment on attachment 479374 [details] [diff] [review]
Likely fix

In the case of REG_BINARY, you need to check dwcbData==sizeof(DWORD).  Otherwise you might potentially operate on random bits.
Attachment #479374 - Flags: review?(ehsan) → review-
did this ever land? my about:support still shows "Adapter RAM Unknown"
You need to log in before you can comment on or make changes to this bug.