In bug 591702 I changed valid_builders.py and reconfig'd the scheduler master but the change was not picked up. We use a lot of |import foo; reload(foo); from foo import bar| for this sort of situation, eg the top of misc.py and process/factory.py. There seems to be a complete absence of that for * buildbotcustom.misc_schedulers at the top of misc.py * in misc_schedulers.py * in try_parser.py
Created attachment 470483 [details] [diff] [review] [tested] import/reload for new additions to buildbotcustom for try_parser just tested this on sm02 and made changes to valid_builders, reconfig'd, and changes were picked up.
Assignee: nobody → lsblakk
Attachment #470483 - Flags: review?(catlee)
Comment on attachment 470483 [details] [diff] [review] [tested] import/reload for new additions to buildbotcustom for try_parser >diff --git a/try_parser.py b/try_parser.py >--- a/try_parser.py >+++ b/try_parser.py >@@ -1,14 +1,19 @@ > # Mozilla Try Parser > # Contributor(s): > # Lukas Blakk <firstname.lastname@example.org> > > import argparse, re >+ > from twisted.python import log >+ >+import buildbotcustom.valid_builders >+reload(buildbotcustom.valid_builders) >+ > from valid_builders import PRETTY_NAMES, DESKTOP_PLATFORMS, MOBILE_PLATFORMS, \ > TALOS_SUITES, UNITTEST_SUITES I think you should turn this into from buildbotcustom.valid_builders import ...
Attachment #470483 - Flags: review?(catlee) → review-
Created attachment 470569 [details] [diff] [review] take 2 - make try reconfig safe nit addressed, fwiw it did work in staging without specifying buildbotcustom.valid_builders
Comment on attachment 470569 [details] [diff] [review] take 2 - make try reconfig safe http://hg.mozilla.org/build/buildbotcustom/rev/5fbfda79d3f5
Attachment #470569 - Flags: checked-in+
should be safe now, closing.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.