If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

try chooser is not reconfig-safe

RESOLVED FIXED

Status

Release Engineering
General
P3
normal
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: nthomas, Assigned: lsblakk)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [try][automation])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
In bug 591702 I changed valid_builders.py and reconfig'd the scheduler master but the change was not picked up. 

We use a lot of |import foo; reload(foo); from foo import bar| for this sort of situation, eg the top of misc.py and process/factory.py. There seems to be a complete absence of that for
* buildbotcustom.misc_schedulers at the top of misc.py
* in misc_schedulers.py
* in try_parser.py
(Assignee)

Comment 1

7 years ago
Created attachment 470483 [details] [diff] [review]
[tested] import/reload for new additions to buildbotcustom for try_parser

just tested this on sm02 and made changes to valid_builders, reconfig'd, and changes were picked up.
Assignee: nobody → lsblakk
Attachment #470483 - Flags: review?(catlee)
Comment on attachment 470483 [details] [diff] [review]
[tested] import/reload for new additions to buildbotcustom for try_parser

>diff --git a/try_parser.py b/try_parser.py
>--- a/try_parser.py
>+++ b/try_parser.py
>@@ -1,14 +1,19 @@
> # Mozilla Try Parser
> # Contributor(s):
> #   Lukas Blakk <lsblakk@mozilla.com>
> 
> import argparse, re
>+
> from twisted.python import log
>+
>+import buildbotcustom.valid_builders
>+reload(buildbotcustom.valid_builders)
>+
> from valid_builders import PRETTY_NAMES, DESKTOP_PLATFORMS, MOBILE_PLATFORMS, \
>                            TALOS_SUITES, UNITTEST_SUITES

I think you should turn this into from buildbotcustom.valid_builders import ...
Attachment #470483 - Flags: review?(catlee) → review-
(Assignee)

Comment 3

7 years ago
Created attachment 470569 [details] [diff] [review]
take 2 - make try reconfig safe

nit addressed, fwiw it did work in staging without specifying buildbotcustom.valid_builders
Attachment #470483 - Attachment is obsolete: true
Attachment #470569 - Flags: review?(catlee)

Updated

7 years ago
Attachment #470569 - Flags: review?(catlee) → review+
(Assignee)

Comment 4

7 years ago
Comment on attachment 470569 [details] [diff] [review]
take 2 - make try reconfig safe

http://hg.mozilla.org/build/buildbotcustom/rev/5fbfda79d3f5
Attachment #470569 - Flags: checked-in+
(Assignee)

Comment 5

7 years ago
should be safe now, closing.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.