59184 - Understanding privacy has 0x96 (long dash) char

Status: RESOLVED INVALID

(Core :: Networking: Cookies, defect, P3)

Description

[Ben Bucksch (:BenB)]

Reproduce:
1. Start fresh Windows 95 (German?) install
2. Install/start Mozilla
3. Tasks|Privacy...|Understanding

Actual result:
There are instances of raw 0x96es in the HTML file. They don't display with the
fonts I had installed. In thebrowser, they display as "|", in Mailnews, they
display as "?".

Either use an HTML entity (look in the HTML spec, I bet, there's a special
entity for the long dash), or replace them wth a normal dash.

Of course, Mozilla should be able to do something more intelligent, but that's
another (old) bug...

Comment 1

[Ben Bucksch (:BenB)]

em, Windows.

Comment 2

[Stephen P. Morse]

There are two occurences in the document of that long dash.  They are at:

   The important point to note is that you are in control - nobody can
   obtain personal information about you unless you explicitly allow them to.

   But the site can read only the cookies that it has stored – it cannot
   read the cookies that other sites have stored.

Comment 3

[Boris Zbarsky [:bzbarsky]]

You should be able to replace those with —

Comment 4

[Stephen P. Morse]

Thanks, I wasn't aware of mdash.

Comment 5

[Stephen P. Morse]

Even though the severity is trivial, so is the patch.  Therefore there's no 
sense not fixing this now.  Attaching patch.

Comment 6

[Stephen P. Morse]

Attachment: patch to changes 0x96 and also "--" to —

Comment 7

[verah (gone)]

r=verah

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 9

[Stephen P. Morse]

Fix checked in.

Comment 10

[Alistair Vining]

Sorry to get really trivial, but these should have been ndash s (0x96 in Windows
charsets) since they're between two spaces.  Or else close up the spaces on
either side.  <ducks>

Comment 11

[Henri Sivonen (:hsivonen)]

Indeed, the custom is to put no spaces around em dashes. Spaces are used around
en dashes.

Comment 12

[Marcia Knous [:marcia]]

Netscape nav triage team: based on Steve Morse's pre-triage recommendation, this 
is not a beta stopper.

Comment 13

[David Hallowell]

Attachment: Patch to turn mdash into ndash as suggested

Comment 14

[David Hallowell]

Such a trivial fix... patch attached. This is the sorta trivial bug that Gerv's
patch maker is really useful for clearing up.

Comment 15

[Stephen P. Morse]

r=morse

Comment 16

[Jesse Ruderman]

Dup of bug 117057?

Comment 17

[Stephen P. Morse]

This dialog has been removed.  So this bug is now invalid.