591841 - 90k Lk increase on switch to omnijar

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Karl Tomlinson (:karlt)]

http://graphs.mozilla.org/graph.html#tests=[[28,1,98]]&sel=1281809882,1282312950

The dip is from omnijar backout:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1362f0ca86d2&tochange=e486018949e2

Rises again
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3900417b9594&tochange=5fcd86df0684

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: diffbloatdump from re-enabling omnijar

Looks like gnomevfs from nsOSHelperAppService::GetMIMEInfoFromOS might be involved.

Comment 2

[Karl Tomlinson (:karlt)]

Has the switch to omni disabled this shortcut?:
http://hg.mozilla.org/mozilla-central/annotate/4f6d1a4cd8ee/netwerk/protocol/res/nsResProtocolHandler.cpp#l209

Comment 3

[Michael Wu [:mwu]]

That part isn't run in omnijar mode. Instead, http://hg.mozilla.org/mozilla-central/annotate/4f6d1a4cd8ee/netwerk/protocol/res/nsResProtocolHandler.cpp#l228 is run which sets up all three resource protocol substitutions and makes them point to the equivalent locations in the omnijar.

Comment 4

[Karl Tomlinson (:karlt)]

I really don't know what's happening here, so just speculating,
wondering if somehow switching to omnijar has caused GetMIMEInfoFromOS to run when it didn't previously (and we didn't see gnomevfs shutdown leaks).
If so, this bug would be more about unnecessary startup operations than memory usage.

Comment 5

[Michael Wu [:mwu]]

Hmm...

nsGnomeVFSService::GetAppForMimeType has a memory leak, if an allocation fails.

And... nsGnomeVFSMimeApp's destructor isn't virtual, and all the references to it use nsIGnomeVFSMimeApp.

Comment 6

[Michael Wu [:mwu]]

(In reply to comment #5)
> And... nsGnomeVFSMimeApp's destructor isn't virtual, and all the references to
> it use nsIGnomeVFSMimeApp.
But I guess that would only apply to its base clase.. nevermind.

Comment 7

[Benjamin Smedberg]

Should be easy to just run a build on Linux and see the stack of GetMIMEInfoFromOS...

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

This was a regression from 12 years ago, marking as no longer valid.