591911 - tabview groups should be represented in about:sessionrestore

Status: RESOLVED WONTFIX

(Firefox :: Session Restore, defect)

Description

[Gordon P. Hemsley [:GPHemsley]]

Right now (in beta 4), the about:sessionrestore dialog does not make any indication about the existence of tab groups. As a result, it lists tabs in a single list, in a seemingly-random order.

Given that the list is already hierarchical with regard to windows, an additional layer of hierarchy should be added with regard to groups.

This also allows the added benefit of using the tab group names as their level indicators, in contrast to the generic "Window 1" indicators for windows.

Comment 1

[Dietrich Ayala (:dietrich)]

a few notes:

- groups will no longer be window specific after bug 578512 lands, so if we do something like this, they'll have to be represented separately from windows somehow.

- groups don't always have a name (i've never named mine).

Comment 2

[Gordon P. Hemsley [:GPHemsley]]

(In reply to comment #1)
> a few notes:
> 
> - groups will no longer be window specific after bug 578512 lands, so if we do
> something like this, they'll have to be represented separately from windows
> somehow.
If that's the case, then the concept of windows need not even exist. (At least, not in Session Restore.)

> - groups don't always have a name (i've never named mine).
True, I'd forgotten about that. But if you don't name your groups, you're probably not using them to the full extent of their usefulness (IMO).

Comment 4

[juan becerra [:juanb]]

This is independent of all-windows Panorama view, but it seems like it should block. I keep seeing things like bug 598707 which to the unsuspecting eye seem like session store-related problems.

Comment 5

[Ian Gilman [:iangilman]]

Here's Aza's design for this feature (section 3 on the page):

https://wiki.mozilla.org/Firefox/Projects/TabCandy/Design/BrowserRestart

We have bug 599213 for the Tab Candy side of the implementation; close as duplicate if this should all happen in one bug.

Comment 6

[Dietrich Ayala (:dietrich)]

This does not block the release. Another level of categorization in the restore UI would be nice, but is not absolutely required for the purpose of narrowing down crashy tabs for selective restoration.

(In reply to comment #4)
> This is independent of all-windows Panorama view, but it seems like it should
> block. I keep seeing things like bug 598707 which to the unsuspecting eye seem
> like session store-related problems.

That is not related to this bug. This bug is about representing groups in the session restore UI.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

We'll implement bug 588217 as part of Panorama displaying all tabs from all windows (so that window == group) and therefore won't need a new level of categorization in about:sessionrestore.