591927 - "Search With" dialog keeps removing menu items on switch of AwesomeScreen panes and or rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre

Currently in the build above, I noticed a new "Search With" dialog that appears when I tap the Menu button on my Android device within the AwesomeScreen. 

On first tap of my devices menu button, I see the following menu items: "Google, Amazon.com, Twitter, Wikipedia"

If I dismiss this menu item, switch panels from All Pages to Bookmarks, and open the menu again, Wikipedia is removed.

If I dismiss this menu item, switch panels from Bookmarks to History, and open the menu again, Twitter is removed.

And so forth until the dialog is compressed and shows nothing

STR:

1. Open Fennec
2. Tap the location bar to open the AwesomeScreen
3. Open the "Search With" dialog 
4. Dismiss dialog and switch panes
5. Open the "Search With" dialog

Notice the removed items.

Comment 1

[Aaron Train [:aaronmt]]

As well, one can see the menu items not properly fitting in the list by having the menu open and rotating the device through landscape and back to portrait

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

The patch tweak a bit the sizeToContent method of the MenuListHelperUI (I've mostly duplicate it from the ContextHelper's one) and also include a few css fixe for the preventing the first row of the menuhelper list to have round border if there is no box title (you can see this failure behavior in the open search list)

Comment 3

[Tony Chung [:tchung]]

flagging for 2.0 triage

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 470442 [details] [diff] [review]
Patch

>diff -r 30398110fbfe chrome/content/browser-ui.js

>-      preferredHeight += popup.children[i].getBoundingClientRect().height;
>+      preferredHeight += popup.childNodes[i].getBoundingClientRect().height;

Why this change?

r+, but if we need the above change, should we add it to ContextHelper?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to comment #4)
> Comment on attachment 470442 [details] [diff] [review]
> Patch
> 
> >diff -r 30398110fbfe chrome/content/browser-ui.js
> 
> >-      preferredHeight += popup.children[i].getBoundingClientRect().height;
> >+      preferredHeight += popup.childNodes[i].getBoundingClientRect().height;
> 
> Why this change?
> 
> r+, but if we need the above change, should we add it to ContextHelper?

We need it because we're not looking into the popup child anymore but we're still doing that for the context helper.

http://hg.mozilla.org/mobile-browser/rev/bb790bfcba55

Comment 6

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Android; Linux armv7l; rv:2.0b5pre) Gecko/20100901 Firefox/4.0b5pre Fennec/2.0a1pre