If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Building w/ gcc 4.2 requires new arch flags for 32 bit

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Tommy Reilly, Assigned: James Sudduth)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
CXXFLAGS=-arch i386
LDFLAGS=-framework CoreServices -arch i386

did the trick, should get this in configure.
(Reporter)

Comment 1

7 years ago
fixed in 4903
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Comment 2

7 years ago
Reopening for Jim to look at. In the buildbot output it is still showing that 10.4, 10.5 32/64 are all still building with gcc 4.0.1

If you look at the stdio for the compile steps in the buildbot waterfall for these machines you will see the output from a call to whatever g++ is going to be used:

This logfile is from a recent 64bit release build:
http://10.171.22.12:8760/builders/mac64-intel-compile/builds/423/steps/Build_Release/logs/stdio

*******************************************************************************
compiler version:
i686-apple-darwin9-g++-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5493)
Copyright (C) 2005 Free Software Foundation, Inc.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 3

7 years ago
after pulling in 4903 things were fixed for me, plain g++ on my machine is:

i686-apple-darwin10-g++-4.2.1: no input files

Comment 4

7 years ago
I think issue might be that the build machines may have been updated from 10.4 and may still have 10.4 default compilers? (machine config issue, or bug in assuming that 10.5/6 will default 10 4.2 compilers)
(Assignee)

Comment 5

7 years ago
Created attachment 470604 [details] [diff] [review]
Force gcc to version 4.2.x on Mac 10.5 and above.

Now, when either the --mac-sdk=10.5 or --mac-sdk=10.6 switch is used, gcc will be set to version 4.2. I ran this in the sandbox and the build machine showed this in the build log:

compiler version:
i686-apple-darwin9-g++-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5577)

All tests passed.
Assignee: nobody → jsudduth
Status: REOPENED → ASSIGNED
Attachment #470604 - Flags: review?(brbaker)

Updated

7 years ago
Attachment #470604 - Flags: review?(brbaker) → review+
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Comment 6

7 years ago
Need to NOT set CC/CXX if it is already in the env. 

rickr: plz change … I use this technique for cross compile …. i.e. setting env on the fly then run make.

treilly: arg, configure.py was nicely making CXX=g++ last week but I pulled from main and now its back to g++-4.0 screwing up my symbol work and valgrind, anyone know what happened before I go hunting?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 7

7 years ago
(In reply to comment #6)
> treilly: arg, configure.py was nicely making CXX=g++ last week but I pulled
> from main and now its back to g++-4.0 screwing up my symbol work and valgrind,
> anyone know what happened before I go hunting?

Ignore this, I was setting the CXX to g++-4.0 from my environ, I think the current script only sets it if you pass --mac-sdk, so rickr's comment might be bunk too.
(Reporter)

Comment 8

7 years ago
actually even specifying --mac-sdk shouldn't trump env settings so yeah, that should be fixed

Comment 9

7 years ago
agreed, if CC/CXX are in the environment, configure should use them.  --mac-sdk should only come into play if CC/CXX isn't set yet.

when in doubt we should adhere to the autoconf/configure/cmake defacto standard for how CC/CXX interact with other options.
(Assignee)

Comment 10

7 years ago
Created attachment 473182 [details] [diff] [review]
Back out previous patch.

The previous patch was inappropriately forcing gcc/gxx to 4.2 whenever --mac-sdk=105 or --mac-sdk=106 was passed in. We'll go back to getting gcc/gxx from the env as before and decouple this from the --mac-sdk switch.
Attachment #470604 - Attachment is obsolete: true
Attachment #473182 - Flags: review?(brbaker)

Comment 11

7 years ago
Comment on attachment 473182 [details] [diff] [review]
Back out previous patch.

patch pushed 5179:9969e3ef0f81
Attachment #473182 - Flags: review?(brbaker) → review+

Comment 12

7 years ago
Comment on attachment 473182 [details] [diff] [review]
Back out previous patch.

Patch pushed as 5179:9969e3ef0f81

Updated

7 years ago
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.