js_Disassemble1 output for JOF_UINT16PAIR

RESOLVED WORKSFORME

Status

()

Core
JavaScript Engine
P2
normal
RESOLVED WORKSFORME
8 years ago
3 years ago

People

(Reporter: Eric Hennigan, Assigned: Eric Hennigan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
User-Agent:       Mozilla/5.0 (compatible; Konqueror/4.4; Linux) KHTML/4.4.2 (like Gecko) Kubuntu
Build Identifier: 


The js_Disassemble1() output for JOF_UINT16PAIR bytecodes is incorrect.

Reproducible: Always

Steps to Reproduce:
1. disassemble any script that uses a JOF_UINT16PAIR bytecode, for example the defsharp opcode:

function  foo() { return #1=[a]; }
print(dis(foo))

Actual Results:  
flags: NULL_CLOSURE
main:
00000:  trace
00001:  newinit 3
00003:  sharpinit 0
00006:  defsharp 0 0
00011:  zero
00012:  name "a"
00015:  initelem
00016:  sharpinit 0
00019:  endinit
00020:  return
00021:  stop

Source notes:
undefined

Expected Results:  
flags: NULL_CLOSURE
main:
00000:  trace
00001:  newinit 3
00003:  sharpinit 0
00006:  defsharp 0 1
00011:  zero
00012:  name "a"
00015:  initelem
00016:  sharpinit 0
00019:  endinit
00020:  return
00021:  stop

Source notes:
undefined
(Assignee)

Comment 1

8 years ago
Created attachment 470524 [details] [diff] [review]
patch to fix disassemble output for JSOF_UINT16PAIR

Updated

8 years ago
Assignee: general → eric.hennigan

Updated

8 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Updated

8 years ago
Severity: trivial → normal
Priority: -- → P2
Resolving as WFM - JOF_UINT16PAIR was removed some time ago.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.