Closed Bug 592115 Opened 9 years ago Closed 9 years ago

Swiping over url bar after the text is cleared brings back the text in a select-all highlight

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(fennec2.0b1+)

VERIFIED FIXED
Tracking Status
fennec 2.0b1+ ---

People

(Reporter: aakashd, Assigned: vingtetun)

Details

Attachments

(1 file)

Build Id:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b5pre) Gecko/20100830 Namoroka/4.0b5pre Fennec/2.0a1pre

Steps to Reproduce:
1. Click on the url bar
2. Tap on the url bar again
3. Clear all the text in the url bar
4. Try to swipe your finger across the url bar again as if you were highlighting the text again

Actual Results:
The text is back and completely highlighted

Expected Results:
The url bar should still be cleared.
tracking-fennec: --- → ?
Before fixing those, we should be sure we want to keep the "double tap" to open the virtual keyboard feature.
How did you clear the text in #3?
I don't understand the steps to repo.
mfinkle,
I guess what aakashd meant in #3 is to clear the text by using the back arrow button of the keyboard. Once the text is cleared, do the step 4 and you will get the text back.
This happens on yesterdays nightly build as well.
I (In reply to comment #2)
> How did you clear the text in #3?
> I don't understand the steps to repo.

I clicked on softkeyboard "del" key on my nexus one.
Attached patch PatchSplinter Review
We were resetting the text of the urlbar on each touch :s
The patch also fixes the 3 taps in landscape Matt was seeing.
Assignee: nobody → 21
Attachment #473613 - Flags: review?(mark.finkle)
(It corrects the 3 taps to open the VKB, sorry for the missing words)
tracking-fennec: ? → 2.0b1+
Comment on attachment 473613 [details] [diff] [review]
Patch

>     }
>+
>   },
> 
>   updateAwesomeHeader: function updateAwesomeHeader(aVisible) {

nit: no need for the blank line
Attachment #473613 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/bf6750e6e92a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
verified FIXED on builds:
Mozilla/5.0 (Maemo; Linux armv71; rv:2.0b6pre) Gecko/20100913 Namoroka/4.0b6pre Fennec/2.0b1pre

and

Mozilla/5.0 (Android; Linux armv71; Nokia N900; en-US; rv:2.0b6pre) Gecko/20100913 Namoroka/4.0b6pre Fennec/2.0b1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.