592152 - Partial fix for const declarations in narcissus

Status: RESOLVED FIXED

(Other Applications Graveyard :: Narcissus, defect)

Description

[Tom Austin]

The attached patch will make const declarations work in Narcissus, rather than have const as a pseudonym for var.

Note that declarations like 'const x;' will still not work correctly.  This might be a little more involved to fix, so I'll open a separate bug for that.

  $ ./njs -e 'const x; x=4; print(x);'
  4

In contrast to spidermonkey:
  $ ./js -e 'const x; x=4; print(x);'
  undefined


Also, updating narcissus-failures.txt.

Comment 1

[Tom Austin]

Attachment: Fix for supporting const declarations

Comment 2

[Dave Herman [:dherman]]

Comment on attachment 470660 [details] [diff] [review]
Fix for supporting const declarations

>                 if (u.readOnly || !hasDirectProperty(t, s)) {
>-                    definitions.defineProperty(t, s, undefined, x.type !== EVAL_CODE, u.readOnly);
>+                    definitions.defineProperty(t, s, undefined, x.type !== EVAL_CODE, false);

Add a comment here that references bug 592335 and explains that this doesn't quite work because of the |const x;| case. But it's fine for now.

r=me with that one change.

Dave

Comment 3

[Tom Austin]

Changelist:  http://hg.mozilla.org/tracemonkey/rev/a80e6f126a1a