Closed Bug 592193 Opened 9 years ago Closed 9 years ago

add dexpcom version of nsIAccessible::role

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b7

People

(Reporter: surkov, Assigned: surkov)

References

Details

(Keywords: access)

Attachments

(3 files)

No description provided.
Marco, could you do full review for the patch, I don't want to bother David here.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #470737 - Flags: review?(marco.zehe)
Attachment #470737 - Flags: approval2.0?
Comment on attachment 470737 [details] [diff] [review]
part1: change GetRoleInternal

r=me with 1 question:
>-  *aRole = primaryCol ?
>+  return primaryCol ?
>     static_cast<PRUint32>(nsIAccessibleRole::ROLE_OUTLINE) :
>     static_cast<PRUint32>(nsIAccessibleRole::ROLE_LIST);

There are three instances of this here. Do we really need tose static_cast operators here any more?
Attachment #470737 - Flags: review?(marco.zehe) → review+
(In reply to comment #2)
> Comment on attachment 470737 [details] [diff] [review]
> part1: change GetRoleInternal
> 
> r=me with 1 question:
> >-  *aRole = primaryCol ?
> >+  return primaryCol ?
> >     static_cast<PRUint32>(nsIAccessibleRole::ROLE_OUTLINE) :
> >     static_cast<PRUint32>(nsIAccessibleRole::ROLE_LIST);
> 
> There are three instances of this here. Do we really need tose static_cast
> operators here any more?

It was linux warning fixed in bug 583076.

I think yes because nothing has been changed technically, I would save this. Perhaps later we'll start to use named enum for roles so we can remove this.
Attachment #471058 - Flags: review?(marco.zehe)
Attachment #471058 - Flags: approval2.0?
Comment on attachment 471058 [details] [diff] [review]
part2: dexpcomed GetRole

r=me
Attachment #471058 - Flags: review?(marco.zehe) → review+
Attachment #471080 - Flags: approval2.0?
Comment on attachment 471080 [details] [diff] [review]
part3: reduce amount of nsAccUtils::Role calls

r=me, thanks!
Attachment #471080 - Flags: review?(marco.zehe) → review+
Attachment #470737 - Flags: approval2.0? → approval2.0+
Attachment #471058 - Flags: approval2.0? → approval2.0+
Attachment #471080 - Flags: approval2.0? → approval2.0+
part2 landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/015684940860
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b7
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.