There's no reason to have a question mark at the end of "Undo?". Following this logic, the other labels should be "Restart now?" and "More?".
Shorlander, need a call here. Boriss' mockups show a question mark on the "Restart Now" and "Undo" links randomly. Which should have question marks if any?
The "following this logic" part of my comment was me being facetious. Links and buttons don't have question marks at the end.
Resolution blocks string freeze
blocking2.0: ? → beta6+
Whiteboard: [good first bug]
Comment on attachment 471097 [details] [diff] [review] Patch v1 You're going to need to change the entity names, I suspect, to ensure that l10n carries over the translation. I suggest addon.undoAction.label and addon.undoRemove.label, but I also do wonder why we have two different labels here :)
Attachment #471097 - Flags: ui-review?(shorlander) → ui-review+
I believe there are two labels because the tooltip for undoUninstall (now undoRemove), is different than the one for undo (undoAction now). I also changed the tooltip's entity names to ensure consistency because we do have two different undos
there we go. Spacing fix
Whiteboard: [good first bug] → [good first bug][strings]
Attachment #471108 - Flags: review?(dtownsend) → review+
Beltzner gave UI+ on patch 1, carrying that forward.
Comment on attachment 471108 [details] [diff] [review] Fix whitespacing, v2.1 No approval needed for blockers, I'm about to land this
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Looks good in 20100902.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.