js_InitArrayClass should make Array.prototype a slow array _ab initio_

RESOLVED WORKSFORME

Status

()

Core
JavaScript Engine
RESOLVED WORKSFORME
7 years ago
a year ago

People

(Reporter: brendan, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
Andreas tried this and broke gmail for want of a length accessor, IIRC. It may have been more subtle than that. I'll try to find the bug.

/be

Comment 1

7 years ago
It was kinda subtle. The code only tolerates making dense arrays that then become slow. The slowification path makes the "length" property on slow arrays. If you allocate a slow array without going through that path, there is no resolve hook to make 'length'.

Comment 2

7 years ago
What's the advantage of doing this?

Comment 3

7 years ago
Its currently born as a dense array, only to be slowified during construction since it contains named properties.
(Assignee)

Updated

3 years ago
Assignee: general → nobody
Slow arrays were removed in https://hg.mozilla.org/mozilla-central/rev/f4671ccc4502.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.