Bring the sexy back to the user-profile edit page's tabs!

VERIFIED FIXED in 5.11.9

Status

addons.mozilla.org Graveyard
Public Pages
P2
normal
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: stephend, Assigned: potch)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 470814 [details]
Screenshot

The tabs on the user-profile edit page don't look good; in particular, the red "remove locale" tab is just hangin' out.
Yeah, I forgot to file this yesterday. Jeff thinks we should just drop l10n from this field, which I am fine with, though we should see how many user profiles are translated.
Target Milestone: --- → 5.11.9
mysql> select count(*) from (select id, count(*) as c from translations where id in (select bio from users where bio is not null) group by id) J where c > 1;
+----------+
| count(*) |
+----------+
|      261 |
+----------+
1 row in set (2.61 sec)

mysql> select count(*) from users where bio is not null;
+----------+
| count(*) |
+----------+
|     3183 |
+----------+
1 row in set (0.00 sec)
So yeah, I'm fine removing l10n but I suspect clouserw will object. In which case we'd need to fix whatever styling is effing up the translation box that looks fine in other places (e.g. admin tools)
I'll object?  Ha, you don't know me at all!</benfolds>

first person to write a patch with a conversion script wins a picture of a cookie
You're the one that insisted on localizing support email addresses and websites. wtf.
Potch sounded like he had a patch in progress for fixing the 2 glitches (remove tab being off and tabs in general being 1 or 2 pixels too low).

I think fixing it will be a lot easier than removing l10n and migrating existing localized bios.
Priority: -- → P2
alright, -> potch then.  We can de-localize it later
Assignee: nobody → thepotch
(Assignee)

Comment 8

8 years ago
http://github.com/jbalogh/zamboni/commit/5c340ba
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

8 years ago
Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/users/edit#user-profile.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.