tbpl should understand Tinderbox's exception status

RESOLVED FIXED

Status

defect
RESOLVED FIXED
9 years ago
4 years ago

People

(Reporter: bhearsum, Assigned: philor)

Tracking

Trunk
x86
macOS
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

Not too long ago we added an "exception" status to Tinderbox, which shows up purple. When bug 505512 lands Thursday morning we're going to start using this for some infrastructure errors and it'd be great if TBPL could pass that along.

You can see an example of this here, in the "OS X 10.6.2 mozilla-central build" column:
http://tinderbox.mozilla.org/showbuilds.cgi?tree=MozillaTest&maxdate=1282888382&hours=24&legend=0&norules=1
Assignee

Comment 1

9 years ago
Posted patch Fix v.1 (obsolete) — Splinter Review
Not sure of a good way to test this, or how to actually pick the colors (other than "start with the #708 that Tinderbox uses"), but if it seems close enough to you, it would be nice if you could push-and-pull this before the downtime in 9 hours or so, since without parts of this, we'll be doing display: none for summaries for exceptions.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #471403 - Flags: review?(mstange)
Assignee

Comment 2

9 years ago
(Not that they are exactly known for useful summaries...)
Comment on attachment 471403 [details] [diff] [review]
Fix v.1

Looks fine so far, but please add an explanation of the new color to the legend.
Attachment #471403 - Flags: review?(mstange) → review-
Assignee

Updated

9 years ago
Assignee: philringnalda → nobody
Assignee

Comment 4

9 years ago
Posted patch Fix v.2Splinter Review
Happened to catch one at the top of a tree, this maybe makes everything work.
Assignee: nobody → philringnalda
Attachment #471403 - Attachment is obsolete: true
Attachment #472554 - Flags: review?(mstange)
Comment on attachment 472554 [details] [diff] [review]
Fix v.2

>diff --git a/js/UserInterface.js b/js/UserInterface.js
>--- a/js/UserInterface.js
>+++ b/js/UserInterface.js
>@@ -140,16 +140,17 @@ var UserInterface = {
>     var legend = $('#legend');
>     for (var name in Config.testNames) {
>       $('<dt>' + Config.testNames[name] + '</dt><dd>' + name + '</dd>').appendTo(legend);
>     }
>     $('<dt>…*</dt><dd>commented</dd>' +  
>       '<dt class="building">gray</dt><dd>building</dd>' +
>       '<dt class="success">green</dt><dd>success</dd>' +
>       '<dt class="testfailed">orange</dt><dd>tests failed</dd>' +
>+      '<dt class="exception">purple</dt><dd>infra exception</dd>' +
>       '<dt class="busted">red</dt><dd>build error</dd>').appendTo(legend);
>   },
> 
>   _updateTimezoneDisplay: function UserInterface__updateTimezoneDisplay() {
>     document.getElementById('localTime').className = this._useLocalTime() ? 'selected' : '';
>     document.getElementById('mvtTime').className = !this._useLocalTime() ? 'selected' : '';
>   },

Spelling it out as “infrastructure” would sure be a better explanation.
Attachment #472554 - Flags: review?(mstange) → review+
Assignee

Comment 6

9 years ago
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/630e22de6a3e
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Assignee

Updated

9 years ago
Depends on: 595082
Assignee

Comment 7

9 years ago
And http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/22c16f1da239 since I can't keep a single word in my head clear through the end of typing it.
I've deployed your two pushes now.
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.