592356 - Fake pages (via url manip) causing 500 on prod

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Tanay Gavankar [:tgavankar]]

If you go to a url that does not exist, such as http://addons.mozilla.org/en-US/firefox/fakepage, the page returned is blank, but it is returning a 500 error.

This does not occur for addon pages that are 404s, such as https://addons.mozilla.org/en-US/firefox/addon/6937125/ which are handled correctly.

Comment 1

[Jeff Balogh (:jbalogh)]

HTTP/1.0 500 Internal Server Error
Server: Apache
X-Backend-Server: pm-app-amo11
Content-Type: text/html; charset=UTF-8
X-Amo-Darklaunch: z
Date: Tue, 31 Aug 2010 18:40:30 GMT
X-Amo-Servedby: pm-app-amo11
Via: Moz-Cache-zlb02
Connection: close
Set-Cookie: X-Mapping-kgbglcod=CCB9EAE0E687FE6259762461D6E3115A; path=/
X-Powered-By: PHP/5.2.9
X-Cache-Info: not cacheable; response code not cacheable
Content-Length: 0

Comment 3

[Justin Scott [:fligtar]]

Why is this WONTFIX?

Comment 4

[Wil Clouser [:clouserw]]

The link in comment 0 is a 404 for me.

Comment 5

[Justin Scott [:fligtar]]

All of these continue to have the problem:

https://addons.mozilla.org/en-US/firefox/fligtar
https://addons.mozilla.org/en-US/firefox/hello
https://addons.mozilla.org/wtf

Comment 6

[Justin Scott [:fligtar]]

also, I really don't like our current policy of immediately WONTFIXing/WORKSFORME when respected contributors clearly have problems. Please ask questions first and shoot later.

Comment 7

[Wil Clouser [:clouserw]]

I wasn't aware of that policy.  It turns out these only have errors if you're logged out.  Please provide more information about your environment if a respected contributor can't reproduce your problem.

This doesn't block dev tools, we can grab it in .7.

Comment 8

[Justin Scott [:fligtar]]

99% of our users are logged out and we serve 225,000 404 responses a day. This is a serious issue that needs immediate attention. This isn't related to dev tools but it needs to go out in the next release, which happens to be dev tools.

I really hope this same issue hasn't been around since August and am surprised automated tests haven't been nagging about this.

Comment 9

[Wil Clouser [:clouserw]]

(In reply to comment #8)
> 99% of our users are logged out and we serve 225,000 404 responses a day. This
> is a serious issue that needs immediate attention. This isn't related to dev
> tools but it needs to go out in the next release, which happens to be dev
> tools.
> 
> I really hope this same issue hasn't been around since August and am surprised
> automated tests haven't been nagging about this.

It's a weird error with our setup and I'll probably need oremj who is out until next weds I think.  We'll try to fit it in.

Comment 10

[Wil Clouser [:clouserw]]

I looked at this today so we could get it into this milestone.  It's the old simple_auth thing.  I changed our default user to [e-mail] which shows the 404 page instead of the "can't find user" 500 error.

Comment 11

[Justin Scott [:fligtar]]

thank you

Comment 12

[krupa raj[:krupa]]

verified fixed @ 

https://addons-next.allizom.org/fr/firefox/wtf
https://addons-next.mozilla.org/en-US/firefox/fligtar
https://addons-next.mozilla.org/en-US/firefox/hello
https://addons-next.mozilla.org/wtf

When logged out, all the above links are 404s