Closed
Bug 592401
Opened 14 years ago
Closed 14 years ago
DomainMgr doesn't need to be virtual interface
Categories
(Tamarin Graveyard :: Virtual Machine, enhancement)
Tamarin Graveyard
Virtual Machine
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stejohns, Assigned: stejohns)
Details
Attachments
(1 file)
|
19.86 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
DomainMgr was written as an abstract interface on the theory that we may want multiple implementations; this now appears unlikely, so we may want to de-virtualize it to avoid the (admittedly minor) overhead of virtual function calls.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → stejohns
Attachment #470867 -
Flags: review?(edwsmith)
|
||
Updated•14 years ago
|
Attachment #470867 -
Flags: review?(edwsmith) → review+
|
|
||
Comment 2•14 years ago
|
||
None of the DomainMgr methods need to be virtual anymore, right? looks like they still are.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Doh -- you're right. Also, DomainMgr is Finalized and doesn't need to be. Will correct prior to landing.
|
|
Assignee | |
Comment 4•14 years ago
|
||
http://hg.mozilla.org/tamarin-redux/rev/d69f1a933615
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•