If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

DomainMgr doesn't need to be virtual interface

RESOLVED FIXED

Status

Tamarin
Virtual Machine
--
enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Steven Johnson, Assigned: Steven Johnson)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
DomainMgr was written as an abstract interface on the theory that we may want multiple implementations; this now appears unlikely, so we may want to de-virtualize it to avoid the (admittedly minor) overhead of virtual function calls.
(Assignee)

Comment 1

7 years ago
Created attachment 470867 [details] [diff] [review]
Patch
Assignee: nobody → stejohns
Attachment #470867 - Flags: review?(edwsmith)

Updated

7 years ago
Attachment #470867 - Flags: review?(edwsmith) → review+

Comment 2

7 years ago
None of the DomainMgr methods need to be virtual anymore, right?  looks like they still are.
(Assignee)

Comment 3

7 years ago
Doh -- you're right. Also, DomainMgr is Finalized and doesn't need to be. Will correct prior to landing.
(Assignee)

Comment 4

7 years ago
http://hg.mozilla.org/tamarin-redux/rev/d69f1a933615
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.