592407 - "View Image" doesn't work on Firefox logo on about:home

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Jesse Ruderman]

Steps to reproduce:
1. Load about:home.
2. Right-click on the Firefox logo.
3. Select "View Image".

Result:

Security Error: Content at about:home may not load or link to chrome://branding/content/icon128.png.

Error: uncaught exception: Load of chrome://branding/content/icon128.png denied.

Comment 1

[Jesse Ruderman]

It's a little worrisome that we're getting a security question wrong.

Comment 2

[Johnathan Nightingale [:johnath]]

The broken experience here doesn't block from a UI point of view, but the CAPS failure might - moving to Core for triage.

Comment 3

[Johnny Stenback (:jst)]

Not a blocker IMO.

Comment 4

[Boris Zbarsky [:bzbarsky]]

What's the bug?

about:home can't link to chrome:// URIs in general.  In the particular context of images (and any other place where the ALLOW_CHROME flag is passed to CheckLoadURI), we allow loads from a chrome package that allows content to access it.  So about:home can load that chrome:// URI in an image tag, but not via various other means, and it cannot link to it.  I don't see a CAPS issue so far.  Jesse, do you?

Comment 5

[Jesse Ruderman]

Would it be safe to change the context menu code to allow View Image on chrome URLs?  If they're "actually images" or something?

Sounds like this isn't a failure of the low-level code, unless we decide that the entire ALLOW_CHROME concept is a bad idea as a result of this problem.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Would it be safe to change the context menu code to allow View Image on chrome
> URLs?

Hmm...  Probably, yes.  It'd be no worse than some of our about: URIs, I guess.

Comment 7

[Marco Bonardo [:mak]]

actually the logo is inserted through a pseudo element, and View Image does not appear.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

I think this is WONTFIX, particularly given comment 7.

Comment 9

[Jesse Ruderman]

Actually, WFM. It's now a

<img id="searchEngineLogo" src="data:image/png;base64,...">

Comment 10

[u393285]

This seems to have regressed. When you right click on the logo, "View Image" appears but selecting it does nothing.

As opposed to comment 9, it's now:

<img id="brandLogo" src="chrome://branding/content/about-logo.png" alt=""/>

Comment 11

[Marco Bonardo [:mak]]

Sure, but still it's not worth fixing it imo, doesn't break any interaction, you can't view image it but that's not supposed to do anything interesting in this context.