Closed Bug 592454 Opened 15 years ago Closed 14 years ago

No error message when editing to make an invalid review

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stephend, Assigned: cvan)

References

()

Details

STR: 1. Log in 2. Load a review 3. Click "Edit Review" 4. Null out the textfield 5. Click "Submit Review" Expected: Error message Actual: https://preview.addons.mozilla.org/en-US/firefox/addon/2848/reviews/237899/edit POST /en-US/firefox/addon/2848/reviews/237899/edit HTTP/1.1 Host: preview.addons.mozilla.org User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8 Accept: application/json, text/javascript, */* Accept-Language: en,en-us;q=0.5 Accept-Encoding: gzip,deflate Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7 Keep-Alive: 115 Connection: keep-alive Content-Type: application/x-www-form-urlencoded; charset=UTF-8 X-Requested-With: XMLHttpRequest Referer: https://preview.addons.mozilla.org/en-US/firefox/addon/2848/reviews/ Content-Length: 102 <snip> Pragma: no-cache Cache-Control: no-cache csrfmiddlewaretoken=71aecd05338a896f9dc9e90634e8e1fa&title=Password+Exporter+is+awesome&rating=4&body= HTTP/1.1 400 BAD REQUEST Server: Apache X-Backend-Server: pm-app-amo24 Cache-Control: no-cache Content-Type: application/json Date: Tue, 31 Aug 2010 21:53:02 GMT Transfer-Encoding: chunked Via: Moz-Cache-zlb03 Connection: close Set-Cookie: multidb_pin_writes=y; Max-Age=15; Path=/ X-Frame-Options: DENY
Yeah that's unfortunate.
Summary: 400 Bad Request error when attempting to submit an empty+edited review → No error message when editing to make an invalid review
Target Milestone: 5.11.9 → 4.x (triaged)
No longer blocks: 583103
With the imapalicization of reviews pages, we now throw error messages upon bad input.
Assignee: nobody → cvan
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: 4.x (triaged) → 6.3.4
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.