fix fullscreen video with OpenGL on Maemo with Qt

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(fennec2.0+)

Details

Attachments

(1 attachment)

Attached small patch fixes fullscreen video with Maemo on Qt.  All small bugs, biggest issue was that Qt seems to disable BLEND under the hood on us, so we weren't getting any alpha blending.  This caused problems.  Also fixes a crash when a window is closed, and fixes a potential issue in case someone doesn't restore the active texture unit.

There's still some weirdness with video playback, but I'm 99.9% certain that it's not due to GL layers code -- I think there might be a timing issue in the decoder (every once in a while we seem to get an old frame? we reuse textures in the GL display code, so it's not like we can use an older frame by accident).  Also there are some stalls during playback sometimes, not sure what's up there.

Tested using identical fullscreen video window from Firefox, opened via same openDialog call from xulrunner.
Attachment #470935 - Flags: review?(jmuizelaar)
Attachment #470935 - Flags: review?(jmuizelaar) → review+
Can we push it? this is important for HW acceleration on meego/maemo Qt.
tracking-fennec: --- → ?
tracking-fennec: ? → 2.0+
http://hg.mozilla.org/mozilla-central/rev/9ddba948c5fb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → vladimir
You need to log in before you can comment on or make changes to this bug.