59247 - nsIDirectoryServiceProvider's need to be threadsafe

Status: VERIFIED FIXED

(Core Graveyard :: Profile: Migration, defect, P3)

Description

[Judson Valeski]

The profile migration thread is using nsIDirectoryServiceProvider which is not
threadsafe.

Comment 1

[Conrad Carlen (not reading bugmail)]

Two providers that need to be threadsafe are:
1) The one at mozilla/modules/appfilelocprovider. This one looks to be already.
2) The one implemented by profile manager. Profile mgr uses the threadsafe
nsISupports macros - whether it actually is threadsafe ??
3) The one at mozilla/modules/mpfilelocprovider. This one also is probably
threadsafe already.

Comment 2

[Doug Turner (:dougt)]

Conrad, are you the new directory service owner?  :-)

Comment 3

[Conrad Carlen (not reading bugmail)]

Sure, this one is pretty easy.

Comment 4

[Conrad Carlen (not reading bugmail)]

-> 0.9.1. Actually, they are threadsafe - they just don't use the nsISupports
macros which say they are.

Comment 5

[Conrad Carlen (not reading bugmail)]

Attachment: uses threadsafe ISUPPORTS macro

Comment 6

[Conrad Carlen (not reading bugmail)]

Using NS_IMPL_THREADSAFE_ISUPPORTS1 avoids the assertion which can happen while
migrating profiles. The object is threadsafe and the only code that it calls
also claims to be threadsafe.

CC'ing dougt for review.

Comment 7

[Judson Valeski]

r=valeski. wow! a real threadsafe class using the thread-safe macros, what a
concept :-).

Comment 8

[Conrad Carlen (not reading bugmail)]

CC'ing jband for sr.

Comment 9

[John Bandhauer]

sr=jband. Looks safe to me.

Comment 10

[Conrad Carlen (not reading bugmail)]

Fix checked in. You'll no longer get the assertion when migrating profiles.

Comment 11

[Grace Bush]

verified code fix