Closed Bug 592601 Opened 9 years ago Closed 9 years ago

Add "face" to the list of white-listed attributes

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- betaN+
blocking1.9.2 --- .11+
status1.9.2 --- .11-fixed
blocking1.9.1 --- .14+
status1.9.1 --- .14-fixed

People

(Reporter: kevin.zh1001, Assigned: ehsan)

References

()

Details

(Keywords: fixed-seamonkey2.0.8, regression, verified1.9.2, Whiteboard: [gs][tb31needed][tb30needed][fixed-tb3.1.4][fixed-tb3.0.8)

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.2.8) Gecko/20100722 Firefox/3.6.8
Build Identifier: 3.1.3

I think there is a problem in the beta version of Thunderbird 3.1.3
we use a HTML file as our signature, in the file, we define the fonts should be Calibri, but when we compose Email, the fonts in the signature was turned into another fonts, such as the system default fonts, but the body of the Email can use the user-defined fonts, like Calibri

Reproducible: Always

Actual Results:  
no change


no additional information
Version: unspecified → 3.1
Duplicate of this bug: 592600
Joe is this one of our known issues ?
I'm unable to test extensively at the moment (I'm on an interim PC) But this looks like a new issue to me. The Font face tag seems to be removed from the original html file when applied as a sig.

kevin, You could help with this by comparing the message source of your html file with the html in the applied sig.(View>>Message source)
A little further testing on this in 
Mozilla/5.0 (Windows NT 5.0; rv:2.0b5pre) Gecko/20100831 Thunderbird/3.2a1pre ID:20100831032343

There have been some recent changes in Core Editor that most likely is involved in this bug (bug 580442) Certain html tags are now sanitized by the editor, and I guess we should add the "font face" tag to that bug.

A work-around would be to use inline styles in the sig instead of a font tag.
Here's an example that works for me.
<span style="font-family: Comic Sans MS;">JoeS
</span>

This preserves the font selection when used in a signature.
Marking as new although this will probably be determined to be a core bug.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to comment #3)
> I'm unable to test extensively at the moment (I'm on an interim PC) But this
> looks like a new issue to me. The Font face tag seems to be removed from the
> original html file when applied as a sig.
> 
> kevin, You could help with this by comparing the message source of your html
> file with the html in the applied sig.(View>>Message source)

Hi Joe, yes, I just compared the html file with the html appied as a sig, the font tag was removed after we applied it as a sig in the mail, only left the font color tag
Thanks
(In reply to comment #4)
> A little further testing on this in 
> Mozilla/5.0 (Windows NT 5.0; rv:2.0b5pre) Gecko/20100831 Thunderbird/3.2a1pre
> ID:20100831032343
> 
> There have been some recent changes in Core Editor that most likely is involved
> in this bug (bug 580442) Certain html tags are now sanitized by the editor, and
> I guess we should add the "font face" tag to that bug.
> 
> A work-around would be to use inline styles in the sig instead of a font tag.
> Here's an example that works for me.
> <span style="font-family: Comic Sans MS;">JoeS
> </span>
> 
> This preserves the font selection when used in a signature.
> Marking as new although this will probably be determined to be a core bug.

yes, the span tag working, thanks
Component: General → Composition
Product: Thunderbird → MailNews Core
QA Contact: general → composition
Version: 3.1 → Trunk
Depends on: 580442
OS: Windows XP → All
Assignee: nobody → ehsan
blocking1.9.1: --- → ?
blocking1.9.2: --- → ?
blocking2.0: --- → ?
Component: Composition → DOM
No longer depends on: 580442
Keywords: regression
Product: MailNews Core → Core
QA Contact: composition → general
Summary: Problem in the signature → Add "face" to the list of white-listed attributes
Attached patch Patch (v1) (obsolete) — Splinter Review
Attachment #472311 - Flags: review?(bzbarsky)
Attachment #472311 - Flags: review?(bzbarsky) → review+
Attachment #472311 - Flags: approval2.0?
Doesn't sound like a blocker to me. If it should be, please say why and renominate.
blocking2.0: ? → -
Attachment #472311 - Flags: approval2.0? → approval2.0+
(In reply to comment #8)
> Doesn't sound like a blocker to me. If it should be, please say why and
> renominate.

I think it should be a blocker, as it is a regression from bug 520189.  For example, if you copy some HTML including a <font face> tag and paste it into an editable field, the face attribute will be lost.
blocking2.0: - → ?
Attached patch For check-inSplinter Review
Attachment #472311 - Attachment is obsolete: true
Keywords: checkin-needed
Ok, thanks for the clarification! Blocking.
blocking2.0: ? → betaN+
http://hg.mozilla.org/mozilla-central/rev/c63f70603dd4
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b6
Attachment #472311 - Flags: approval1.9.2.10?
Attachment #472311 - Flags: approval1.9.1.13?
blocking1.9.1: ? → .13+
blocking1.9.2: ? → .10+
Comment on attachment 472682 [details] [diff] [review]
For check-in

Approved for 1.9.2.10 and 1.9.1.13, a=dveditz for release-drivers
Attachment #472682 - Flags: approval1.9.2.10+
Attachment #472682 - Flags: approval1.9.1.13+
Attachment #472311 - Flags: approval1.9.2.10?
Attachment #472311 - Flags: approval1.9.1.13?
Whiteboard: [gs][tb31needs][tb30needs](?)
Duplicate of this bug: 594360
I also re-imported this on the 1.9.1.12 relbranch as http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1389736dbf5f with permission over IRC from LegNeato. SeaMonkey will take this as a ride-along on our 2.0.8 oilspill release.
(In reply to comment #16)
> I also re-imported this on the 1.9.1.12 relbranch as
> http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1389736dbf5f with permission
> over IRC from LegNeato. SeaMonkey will take this as a ride-along on our 2.0.8
> oilspill release.

Great!  Maybe Thunderbird could do the same?
Whiteboard: [gs][tb31needs][tb30needs](?) → [gs][tb31needed][tb30needed][fixed-tb3.1.4][fixed-tb3.0.8
Verfifed Fixed with Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.2.9) Gecko/20100910 Thunderbird/3.1.4
Status: RESOLVED → VERIFIED
Duplicate of this bug: 595491
Since Ludovic verified this for 1.9.2, adding the 'verified1.9.2' keyword.
Keywords: verified1.9.2
Verified for 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.12) Gecko/20100923 Shredder/3.0.9pre. The face attribute is preserved now in the signature.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.