592653 - Use Services.prefs instead of preferences-service / gPrefService

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Ian Neal]

Neil noticed that whilst I was working on update SeaMonkey's browser_bug515006.js that Firefox's browser_354894.js was still using gPrefService rather than Services.prefs
This should probably be fixed and elsewhere, if appropriate.

Comment 1

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/search?string=gPrefService&case=1&find=%2Ftest
"Found 207 matching lines in 58 files"

/mozilla/docshell/test/browser/browser_bug435325.js : I filed bug 707570.

See also
/mozilla/toolkit/components/search/tests/xpcshell/test_645970.js
2 /suite/common/tests/browser/browser_*.js
(other tests are Firefox specific...)

***

http://mxr.mozilla.org/comm-central/search?string=preferences-service&case=1&find=%2Ftest
"Found 384 matching lines in 305 files"

Comment 2

[Roberta]

Hi, I'd like to fix this bug.
Do I have to replace all "gPrefService." in here: http://mxr.mozilla.org/comm-central/search?string=gPrefService&case=1&find=%2Ftest with "Services.Prefs."?

Comment 3

[Amod [:AMoz]]

since there is no news from Roberta, I would like to contribute to the bug.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

sgautherie, are you still interested in mentoring this bug?

Comment 5

[Amod [:AMoz]]

As the assignee, I request you for 1 week's time. I would return to bugzilla soon. Thanks !

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #1)

> http://mxr.mozilla.org/comm-central/search?string=gPrefService&case=1&find=%2Ftest
> "Found 207 matching lines in 58 files"

"Found 159 matching lines in 40 files":
*The first 39 are in /browser: WontFix'ed in bug 716258 :-/
*The last one is in /toolkit: should be fixed, as in bug 707570.

> ***
> 
> http://mxr.mozilla.org/comm-central/search?string=preferences-service&case=1&find=%2Ftest
> "Found 384 matching lines in 305 files"

"Found 195 matching lines in 167 files"
"50% done", yet still a lot of files (though probably not all) to update.

***

Select the part(s) you are interested in, file blocking bugs, fix them ;-)

Comment 7

[Pavan Karthik [:matrixisreal]]

Hi, Im new to testing and would love to work on this bug.
It would be helpful if you let me know on how to start with and some good links about testing would be awesome. :d
thanks. :D

Comment 8

[Florian Quèze [:florian]]

Attachment: script-generated patch

This patch was produced with the script at https://bitbucket.org/fqueze/xpcshell-rewrites/commits/8bbf5751b38d617798cb1da7105b14b49320f90a which preserves indentation.

Comment 9

[Florian Quèze [:florian]]

Attachment: remove gPrefService from browser.js

We no longer care about add-on compat, so we can remove the browser.js lazy getter.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8937810 [details] [diff] [review]
script-generated patch

Review of attachment 8937810 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice. You might want to pass it through try before landing, just in case.

nit: "Bug 592653 - script-generated patch to replace gPrefService with Services.prefsfrom browser.js, r=Standard8."

missing space after prefs.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8937811 [details] [diff] [review]
remove gPrefService from browser.js

Review of attachment 8937811 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup, less globals! :-)

Comment 12

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d929040a0cfe09b98f0edccf109665244efe616

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/abbde724b07a
script-generated patch to replace gPrefService with Services.prefs, r=Standard8.
https://hg.mozilla.org/integration/mozilla-inbound/rev/2171fb0b3801
remove gPrefService from browser.js, r=Standard8.

Comment 14

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/abbde724b07a
https://hg.mozilla.org/mozilla-central/rev/2171fb0b3801