Closed Bug 592704 Opened 14 years ago Closed 14 years ago

buildbotcustom.steps.SendChangeStep needs to watch stdout for success

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gozer, Assigned: gozer)

Details

Attachments

(1 file, 1 obsolete file)

SendChange also checks for expected success message from buildbot v2
588 bytes, patch
bhearsum
: review+
mozilla
: checked-in+
Details | Diff | Splinter Review 
I just discovered that under some failure conditions (i.e. the master address used isn't in DNS), buildbot sendchange (as invoked by SendChangeStep) will return a successful status code, when really, it shouldn't.

The suggested fix I've made is to watch for the status code *and* the expected buildbot output (change sent successfully)
Attachment #471160 - Flags: review?(bhearsum) → review+
Comment on attachment 471160 [details] [diff] [review]
SendChange also checks for expected success message from buildbot

Landed on default and 0.8.0
changeset:   951:cf01d51284a8

changeset:   952:2ea18577cbad
Attachment #471160 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
backed out due to bustage.

The quoting here probably didn't work out. This was executed through execvp():
 argv: ['python', '/builds/slave/tryserver-linux/tools/buildfarm/utils/retry.py', '-s', '5', '-t', '1800', '-r', '5', '--stdout-regexp="change sent successfully"', 'buildbot', 'sendchange', '--master', 'production-master01.build.mozilla.org:9009', '--username', 'catlee@mozilla.com', '--branch', 'tryserver-linux-talos', '--revision', '682717b2db1a', 'http://stage.mozilla.org/pub/mozilla.org/firefox/tryserver-builds/catlee@mozilla.com-682717b2db1a/tryserver-linux/firefox-4.0b3pre.en-US.linux-i686.tar.bz2']
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sorry, but you are correct. This is going via exec, so quoting was wrong. Follow-up patch fixes this and has been running on MoMo/Try for a day now.
Attachment #471160 - Attachment is obsolete: true
Attachment #471611 - Flags: review?(bhearsum)
Ben, looks like you are working on this.
Assignee: nobody → bhearsum
I think this belongs to gozer, actually.
Assignee: bhearsum → gozer
Attachment #471611 - Flags: review?(bhearsum) → review+
Flags: needs-reconfig?
Comment on attachment 471611 [details] [diff] [review]
SendChange also checks for expected success message from buildbot v2

http://hg.mozilla.org/build/buildbotcustom/rev/1e8a3a2ffabc (buildbot-0.8.0)
http://hg.mozilla.org/build/buildbotcustom/rev/71e74d11afa4 (default)
Attachment #471611 - Flags: checked-in+
landed and reconfiged; hopefully it sticks this time.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Flags: needs-reconfig?
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: