592748 - Code-coverage - AS3 Classes: Date

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Tools, defect)

Description

[Chris Peyer]

as of redux r5139:
                        covered      total        covered    total      
class                 functions  functions   pct     cond     cond   pct
Date                         58         61  95.1      163      191  85.3

Coverage of:
avmplus::Date::
avmplus::DateClass::
avmplus::DateObject::

Comment 1

[Dan Schaffer]

From Date,DateClass,DateObject I get 84 functions and 417 conditions.  I think the difference is global functions within the Date.cpp file.  My results with patch are:
Class                                   Function Coverage           C/D Coverage
---------------------  ---------------------  ---------------------
avmplus::DateObject::      39 /    39 = 100%          8 /    10  =  80%
avmplus::DateClass::        6 /     6    = 100%         65 /    80 =  81%
avmplus::                           84 /    84 = 100%     345 /   417 =  82%
avmplus::Date::                14 /    14 = 100%       92 /   101 =  91%
---------------------  ---------------------  ---------------------
Total                                   84 /    84 = 100%     345 /   417 =  82%

Comment 2

[Brent Baker]

Attachment: Testcase for Date construction

Testcase to cover conditions in:
avmplus::MakeDay()
avmplus::MakeTime()

Comment 3

[Dan Schaffer]

Attachment: new Date tests

merged Brent's constructor.as with new selftest for date.

Comment 4

[Brent Baker]

Comment on attachment 485116 [details] [diff] [review]
new Date tests

// TEST: constructor with Date object
- Should test that the constructed date is actually the same as the passed in date instead of just !=NULL
d2->getTime()==d1->getTime()

// TEST: toStringInvalid
- Should verify that res==false, I assume this is the test that the formatIndex hits the default switch case which returns false.

// TEST: setDate negative values
- I don't see a code path in Date::setDate() that actually deals with negative values, this is just being passed into Date::MakeDay()

// TEST setDate NaN
- Do these overlap with as3/Date/constructor.as?

as3/Date/timezone.as
- The second test name is incorrect, it is not testing "test Date getTimezoneOffset" it is calling secondsUTC. Could this testcase also set the secondsUTC to some value that it is not already and confirm that it is set properly?
  * Currently d1 is already created with seconds==0, so maybe calling d1.secondsUTC=12, then you can test that d1.seconds==12 instead of just !=NULL, which it already was.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.