592779 - Sharing a private addon collection is useless

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P2)

Description

[Kevin Brosnan]

Create a collection
Make it private
Go to the collection's main page
Click share this collection

Digg won't allow you to submit the url because there is no content.
Facebook and Twitter will accept the post. I don't have accounts for Delicious or FriendFeed.

However sharing this url is useless as linking to a private collection just shows a blank page.

Either sharing should be removed from private collections or there should be a way to request access to the collection.

Comment 1

[Justin Scott [:fligtar]]

Yeah, private collections are supposed to have sharing disabled.

See https://bugzilla.mozilla.org/show_bug.cgi?id=574283#c6

Comment 2

[Wil Clouser [:clouserw]]

-> potch.  Should be a quick if() around that link

Comment 3

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/c71f680

Comment 4

[krupa raj[:krupa]]

Sharing is still available for private collections. Reopening

Comment 5

[Potch [:potch]]

laggy preview is laggy.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Kevin/Krupa: this WFM; how about you, now?

Comment 8

[Kevin Brosnan]

Still shows on my pre-existing collection. But a new collection does not show the sharing link.

Comment 9

[Kevin Brosnan]

Attachment: pre-existing collection

Comment 10

[Jeff Balogh (:jbalogh)]

(In reply to comment #9)
> Created attachment 471507 [details]
> pre-existing collection

A private collection would have (private) in the title.

Comment 11

[krupa raj[:krupa]]

wfm now.Marking this verified.