Closed
Bug 592837
Opened 14 years ago
Closed 14 years ago
Can't save images anymore
Categories
(Camino Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: contact, Assigned: alqahira)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.47 KB,
patch
|
bugzilla-graveyard
:
review+
stuart.morgan+bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en; rv:1.9.2.10pre) Gecko/20100829 Camino/2.1a1pre (like Firefox/3.6.10pre) Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en; rv:1.9.2.10pre) Gecko/20100829 Camino/2.1a1pre (like Firefox/3.6.10pre) When clicking View Image in the contextual menu, Save As is disabled. Reproducible: Always Steps to Reproduce: 1.Open an image file Actual Results: "File > Save As..." is disabled. Expected Results: Saving should be possible.
Assignee | ||
Comment 1•14 years ago
|
||
WFM in 2010-08-31 on 10.5.
Reporter | ||
Comment 2•14 years ago
|
||
I've just installed the latest nightly (20100901) and still have the problem. And I can reproduce with Troubleshoot Camino.
Comment 3•14 years ago
|
||
I can reproduce this on 10.6, yesterday's and today's nightlies.
Comment 4•14 years ago
|
||
Right, indeed File > Save as is disabled - once you view the image as standalone. I see that on both 10.5 and 10.6. It works correctly with the 20100821 build; I'll check when this broke. STR: 1. right click on image > View image 2. File > Save as… AR: the menu item is disabled.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 5•14 years ago
|
||
works Version 2.1a1pre (1.9.2.10pre 20100825001540) -- rev/0b767dcfd281 fails Version 2.1a1pre (1.9.2.10pre 20100826001526) -- rev/f70bb96c693f http://hg.mozilla.org/camino/pushloghtml?fromchange=0b767dcfd281&tochange=f70bb96c693f --> bug 587552 btw - the context menu item after step 1 in my previous comment still has Save Image … active.
Comment 6•14 years ago
|
||
Yep, the second hunk probably broke this. It added validation of |savePage| to a conditional that requires text-based content. Images, obviously, aren't text-based content and fail the conditional.
Assignee | ||
Comment 7•14 years ago
|
||
Oops :( This moves savePage: to its own validation, based on the one it came from originally (print/page setup) with the addition of the error page check that bug 587552 intended to add for savePage:.
Assignee | ||
Updated•14 years ago
|
Blocks: 587552
Keywords: regression
Comment 8•14 years ago
|
||
Comment on attachment 471338 [details] [diff] [review] Fix This looks right, although I haven't built and tested it.
Attachment #471338 -
Flags: superreview?(stuart.morgan+bugzilla)
Attachment #471338 -
Flags: review?(cl-bugs-new2)
Attachment #471338 -
Flags: review+
Comment 9•14 years ago
|
||
Comment on attachment 471338 [details] [diff] [review] Fix sr=smorgan. I wish we could abstract some of these "what you see is not what you get when saving/printing" a bit more, but apparently they don't all behave the same way?
Attachment #471338 -
Flags: superreview?(stuart.morgan+bugzilla) → superreview+
Comment 10•14 years ago
|
||
Oops, s/?/./ since we established in IRC that they do in fact not behave the same.
Assignee | ||
Comment 11•14 years ago
|
||
Specifically, save tries to act on the underlying page, whereas print acts on the displayed content (though we disabled printing on the safebrowsing-blocked sites in bug 501246 for p-Safari, which is why save was jumping around in these two patches). http://hg.mozilla.org/camino/rev/86e64794f790
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•