592903 - Change screen resolution of Mac 10.5 slaves to 1600x1200

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See bug 580410.

For reftests to work properly we need the entire reftest window to fit onto the screen. Hiding the reftest window titlebar makes it fit on 1280x1024, but that's suboptimal for developers since the reftest window titlebar shows progress and is useful for moving the reftest window.

So, please change the Mac slave resolution to 1680x1050 (and ensure the dock is moved to the left or right of the screen). On my laptop, that makes the reftest window fit with its titlebar. Thanks!

Comment 1

[Armen [:armenzg]]

I will get to this in the next 3 weeks.

Anyone is welcome to take it.

Comment 2

[Armen [:armenzg]]

(In reply to comment #0)
> So, please change the Mac slave resolution to 1680x1050.
I am looking at 1400x1050 as 1680x1050 is not offered on the machines (the next one is 1600x1200).

Is this good?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, that sounds good.

Comment 4

[Armen [:armenzg]]

I have run talos runs (for c9573f457db9) on staging with the new screen resolution and after comparing staging and production numbers I can only worth mentioning variations for the following suites (staging/production):
* ts_cold_shutdown: 165.47/201.74
* ts_places_generated_max_shutdown: 174.53/160.11
* tscroll: 13234.4/13358.2

I will run this again several times to see if it happens again.

Comment 5

[Armen [:armenzg]]

Attachment: talos numbers comparison with changed screen resolution on Leopard machines

I have run this again on staging and got 3 runs of each suite (getting the numbers is such a painful task).

It seems that shutdown is somehow affected with the screen resolution changes:
(production - staging 1st run/2nd run/3rd run)
* ts_shutdown: 328.84 - 201.42/187.53/188.47
* ts_cold_shutdown: 189.58 - 229.63/189.79/189.58
* tp4_shutdown: 882.0 - 898.0/1124.0/1104.0

NOTES:
* I believe the ts_shutdown in the production is a little off from others run I have seen on other production runs (which where around 220).
* The first run on staging of ts_cold_shutdown sounds off. The last two were run on the same machine.
* For tp4_shutdown, the last two values are a little off.

Who could analyze my talos numbers and tell me if it is fine to change the screen resolution on all Leopard testing slaves?
Who can make that call?

We could also change the screen resolution on the fly by doing this:
/Users/cltbld/cscreen -x 1600 -y 1200 -r 60 -d 32 -f
and then setting to its default on reboot. To be honest, this is also a scary change as I don't know into which weird situations we could get into.

This option AFAIK is not viable for Fedora testing machines as we have not yet discovered a reliable way to change the screen resolution for a test run.

Comment 6

[Armen [:armenzg]]

As per joe's comment we should make it the new default once we get approval by roc or him.
Adding them to make the call on this.

Comment 7

[Joe Drew (not getting mail)]

These look like meaningful changes on the shutdown timings (these tests' standard devitation is pretty low), but I wouldn't be terribly concerned about it all the same. We need this resolution change so we're testing something closer to what our users use.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I think we should just change it now.

Comment 9

[Armen [:armenzg]]

Please bring it up on Tuesday meeting so we can get a clear "go" on this.
It does not require a downtime but it is cautious to do it early in the day.

Comment 10

[Armen [:armenzg]]

Starting from this morning all Rev3 Leopard testing machines have a screen resolution of 1600x1200x60hz instead of 1280x1024x60hz.

I have notified this on dev.planning and dev.tree-management
http://groups.google.com/group/mozilla.dev.planning/browse_thread/thread/453a0270c6a44d5b/2823e8caa5a3b286#2823e8caa5a3b286

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Was this change manually on each machine ?

Comment 12

[Armen [:armenzg]]

This got deployed by providing a new /Library/LaunchAgents/cscreen.resize.plist which has 2 lines changed for new screen resolution (s/1280/1600/ and s/1024/1200).