Closed Bug 592910 Opened 11 years ago Closed 11 years ago

TM: simplify IsEntryTypeCompatible()

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

In an old profile of V8, ISEntryTypeCompatible() was significant in the trace-jit.  It doesn't appear to be any more, but in the meantime I simplified it and I figure the readability win is worth keeping.
Attachment #471362 - Flags: review?(lw)
Here's a version of the patch that actually compiles.
Attachment #471362 - Attachment is obsolete: true
Attachment #471363 - Flags: review?(lw)
Attachment #471362 - Flags: review?(lw)
Comment on attachment 471363 [details] [diff] [review]
patch, v2 (against TM 52722:b360dd204dc6)

Looks good.
Attachment #471363 - Flags: review?(lw) → review+
http://hg.mozilla.org/tracemonkey/rev/8cdd45050d87
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/8cdd45050d87
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.