592920 - Assertions when typing into the password field at smithbarney.com

Status: RESOLVED DUPLICATE of bug 586662

(Core :: DOM: Editor, defect)

Description

[(no longer active)]

From bug 592663 comment 7:

When I type one letter into the password field after tabbing I get these
assertions:

###!!! ASSERTION: bad action nesting!: 'mActionNesting>0', file
../../../../editor/libeditor/text/nsTextEditRules.cpp, line 250
###!!! ASSERTION: bad state: 'mUpdateCount > 0', file
../../../../editor/libeditor/base/nsEditor.cpp, line 4080
###!!! ASSERTION: already started a batch!: '!mRootVM', file
../../../dist/include/nsIViewManager.h, line 304
###!!! ASSERTION: bad action nesting!: 'mActionNesting>0', file
../../../../editor/libeditor/text/nsTextEditRules.cpp, line 250

Comment 2

[(no longer active)]

Attachment: Test case 1

In this test case, when you type a character into the text box, nsTextEditorState::PrepareEditor is called too soon with this stack:

#0	0x132d68ae in nsFrameSelection::StartBatchChanges at nsSelection.cpp:2240
#1	0x132d6c47 in nsTypedSelection::StartBatchChanges at nsSelection.cpp:5668
#2	0x1398ae9e in nsEditor::DoTransaction at nsEditor.cpp:652
#3	0x1397d677 in nsEditor::DeleteSelectionImpl at nsEditor.cpp:4268
#4	0x139739f3 in nsTextEditRules::WillDeleteSelection at nsTextEditRules.cpp:935
#5	0x139750ff in nsTextEditRules::WillDoAction at nsTextEditRules.cpp:326
#6	0x13966915 in nsPlaintextEditor::DeleteSelection at nsPlaintextEditor.cpp:785
#7	0x139741fc in nsTextEditRules::WillInsertText at nsTextEditRules.cpp:681
#8	0x139750c9 in nsTextEditRules::WillDoAction at nsTextEditRules.cpp:324
#9	0x13966ec9 in nsPlaintextEditor::InsertText at nsPlaintextEditor.cpp:832
#10	0x13667a03 in nsTextEditorState::SetValue at nsTextEditorState.cpp:1729
#11	0x13669dbb in nsTextEditorState::PrepareEditor at nsTextEditorState.cpp:1284
#12	0x1366bfe0 in PrepareEditorEvent::Run at nsTextEditorState.cpp:994
#13	0x134c821e in nsContentUtils::RemoveScriptBlocker at nsContentUtils.cpp:4746
#14	0x131a7c25 in nsAutoScriptBlocker::~nsAutoScriptBlocker at nsContentUtils.h:1889
#15	0x1322918d in PresShell::FlushPendingNotifications at nsPresShell.cpp:4781
#16	0x13985334 in nsEditor::EndUpdateViewBatch at nsEditor.cpp:4205
#17	0x13988e2f in nsEditor::EndPlaceHolderTransaction at nsEditor.cpp:921
#18	0x1396ed5d in nsAutoPlaceHolderBatch::~nsAutoPlaceHolderBatch at nsEditorUtils.h:65
#19	0x13966ae4 in nsPlaintextEditor::TypedText at nsPlaintextEditor.cpp:450
#20	0x1396c1cb in nsPlaintextEditor::HandleKeyPressEvent at nsPlaintextEditor.cpp:419
#21	0x13995b44 in nsEditorEventListener::KeyPress at nsEditorEventListener.cpp:344
#22	0x136058b9 in DispatchToInterface at nsEventListenerManager.cpp:175
#23	0x13607052 in nsEventListenerManager::HandleEventInternal at nsEventListenerManager.cpp:1204
#24	0x13637bde in nsEventListenerManager::HandleEvent at nsEventListenerManager.h:146
#25	0x13637da1 in nsEventTargetChainItem::HandleEvent at nsEventDispatcher.cpp:212
#26	0x13635f54 in nsEventTargetChainItem::HandleEventTargetChain at nsEventDispatcher.cpp:341
#27	0x13636159 in nsEventTargetChainItem::HandleEventTargetChain at nsEventDispatcher.cpp:395
#28	0x13636e62 in nsEventDispatcher::Dispatch at nsEventDispatcher.cpp:628
#29	0x13215a35 in PresShell::HandleEventInternal at nsPresShell.cpp:6744
#30	0x13227b7f in PresShell::HandleEvent at nsPresShell.cpp:6499
#31	0x13226968 in PresShell::HandleEvent at nsPresShell.cpp:6223
#32	0x13811010 in nsViewManager::HandleEvent at nsViewManager.cpp:1120
#33	0x13815534 in nsViewManager::DispatchEvent at nsViewManager.cpp:1098
#34	0x1380e59a in HandleEvent at nsView.cpp:161
#35	0x12fa908c in nsChildView::DispatchEvent at nsChildView.mm:1715
#36	0x12fa5882 in nsChildView::DispatchWindowEvent at nsChildView.mm:1725
#37	0x12fbc79c in -[ChildView insertText:] at nsChildView.mm:4648
#38	0x929955ae in -[NSTextInputContext insertText:replacementRange:]
#39	0x9299354b in -[NSTextInputContext handleTSMEvent:]
#40	0x92992ad9 in _NSTSMEventHandler
#41	0x93e92f2f in DispatchEventToHandlers
#42	0x93e921f6 in SendEventToEventTargetInternal
#43	0x93eb49bb in SendEventToEventTarget
#44	0x93f16ad2 in SendTSMEvent
#45	0x93f1644f in SendUnicodeTextAEToUnicodeDoc
#46	0x93f16059 in TSMKeyEvent
#47	0x93f06fde in TSMProcessRawKeyEvent
#48	0x929923b8 in -[NSTextInputContext handleEvent:]
#49	0x9298e229 in -[NSView interpretKeyEvents:]
#50	0x12fb18d8 in -[ChildView processKeyDownEvent:] at nsChildView.mm:5113
#51	0x12fad5df in -[ChildView keyDown:] at nsChildView.mm:5266
#52	0x928c2f6c in -[NSWindow sendEvent:]
#53	0x12f9a522 in -[ToolbarWindow sendEvent:] at nsCocoaWindow.mm:2339
#54	0x927dbaff in -[NSApplication sendEvent:]
#55	0x9276f5bb in -[NSApplication run]
#56	0x12f945c1 in nsAppShell::Run at nsAppShell.mm:747
#57	0x15e1e740 in nsAppStartup::Run at nsAppStartup.cpp:191
#58	0x00011a8a in XRE_main at nsAppRunner.cpp:3665
#59	0x00002615 in main at nsBrowserApp.cpp:158
#60	0x00002296 in start

Which causes the batch change count to be corrupted.

Comment 3

[Timothy Nikkel (:tnikkel)]

Bug 240933 makes it so we only get one assertion:
###!!! ASSERTION: Bad mBatching: 'mBatching >=0', file ../../../layout/generic/nsSelection.cpp, line 2247

Comment 4

[(no longer active)]

The remaining assertions will be fixed by my patches in bug 586662.

Comment 5

[(no longer active)]

In fact, based on the test case, this is a dupe of that bug!