593004 - Quick search selected filters are ellipsoids not squared with rounded corners anymore

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Ludovic Hirlimann [:Usul]]

Attachment: screen shot of the issue.

I'm pretty sure this regressed either today or yesterday. I'm filling this in Thunderbird but it's probably a Core issue, feel free to move to the appropriate component (which I'm unable to figure out).

See the screenshot for how the selection appears on filters in the quick search bar.


getting that with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0b6pre) Gecko/20100901 Thunderbird/3.2a1pre

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

I just looked at our pinstripe theme and we have:
  -moz-border-radius: 100%;

So the ellipse seems right for border-radius suggesting there was a graphic involved or something.

Comment 2

[Andreas Nilsson (:andreasn)]

From https://developer.mozilla.org/en/CSS/-moz-border-radius:
"Note:  In Gecko 2.0 (Firefox 4.0) the handling of <percentage> values changed to match the latest specification."
"Starting Gecko 2.0 (Firefox 4.0): Percentages for the horizontal radius are relative to the width of the border box, whereas percentages for the vertical radius are relative to the height of the border box."

I guess this is what happened here, and it seems correct that it now draws a round thing according to that. Will come up with a fix!

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: pinstripe patch

Since the height of the element is 18px, making the rounding to 9px will achieve the right effect.

Comment 4

[Andreas Nilsson (:andreasn)]

Does this bug affect Windows 7 too? I can't see it on my Vista system.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 472607 [details] [diff] [review]
pinstripe patch

rs=asuth (by inspection)

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

I was just pointed to bug 471643 and attachment 470834 [details] [diff] [review] in it which seems to be tackling this issue in FF

Comment 7

[Ludovic Hirlimann [:Usul]]

Bryan - ping for the UI review ? can we land this ?

Comment 8

[Andreas Nilsson (:andreasn)]

I was reminded on IRC that we shouldn't use -moz-border-radius, but border-radius now instead. Will come up with a new patch to address this.

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: updated patch

Updated patch using border-radius instead. Assuming this will get r+ and ui-r+ as it's basically the same as before.

Comment 10

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/d02bac079d20