593061 - setTimer / setInterval don't behave as expected

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

setTimeout & setInterval behaves differently from the browsers native same named functions.

Example:

setTimeout(function(test) { console.log(Array.prototype.slice(arguments)) }, 0, 'some data', 3, 'bla');

Expected behavior:
"some data,3,bla" to be logged in the console
Actual behavior:
""

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Fix

Comment 2

[Atul Varma [:atul]]

Comment on attachment 471534 [details] [diff] [review]
Fix

Cool, do you think you could add tests for this in tests/test-timer.js though?

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: adding test + docs

Sure!! Don't know why forgot to do that in a first patch.

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

diff view: http://github.com/Gozala/jetpack-sdk/compare/master...timer@593061

Comment 5

[Atul Varma [:atul]]

Comment on attachment 471795 [details] [diff] [review]
adding test + docs

Awesome! Do you have commit access to the repo yet, or should I commit it?

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

No I don't have it yet.
Wold be nice if you'll commit it.

Comment 7

[Atul Varma [:atul]]

Hey, is this patch bit-rotted or anything? I'm trying to commit it, but I'm getting a weird "hunk failure" on test-timer.js.

I'm going to keep this bug open until it's landed, if that's ok--otherwise I might lose track of it.

Comment 8

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I sew it was committed already:
https://hg.mozilla.org/labs/jetpack-sdk/rev/0c846452f77c

I thought it was you.. Guess you can commit because patch is already in your tip

Comment 9

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I meant you can't because ...

Comment 10

[Atul Varma [:atul]]

Oh, nice! Sorry about that, re-marking the bug as fixed.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".