593150 - Searching for "searchmenu - search faster" fails on preview, but works on prod

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Search, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Searching for "searchmenu - search faster" fails on preview [1], but works on production [2]

"searchmenu" works by itself, though I just don't know what else this might break (other add-ons with spaces/hypens in their names?)

[1] https://preview.addons.mozilla.org/en-US/firefox/search/?q=searchmenu+-+search+faster&cat=all&lver=any&pid=1&sort=&pp=20&lup=&advanced=
[2] https://addons.mozilla.org/en-US/firefox/search/?q=searchmenu+-+search+faster&cat=all&lver=any&pid=1&sort=&pp=20&lup=&advanced=

Comment 1

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

hyphen's need to be in quotes, quoting the whole string works.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

We made this change on purpose, to fix another bug?  I'm fine with that, if that's true.  Just found a case where "All-in-one sidebar" (minus the quotes, of course) now isn't found on preview, but is on prod.  Granted, users can still find it by searching for "All in one sidebar" (again, sans quotes).

I just want us to be sure we're aware of and happy with this change.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Yes - but there may be a way to undo it if necessary.

I think this was to fix the myriad of other "I can't find these crazy character bugs"

Comment 4

[Jeff Balogh (:jbalogh)]

I'd think we should favor hyphens in search strings and say "oh well" to the gotcha bugs.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Let's revisit this; it breaks searches like in bug 595190.

Comment 6

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Now the opposite is true. Works in preview, broken in prod.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.