Closed Bug 593153 Opened 14 years ago Closed 13 years ago

Web Console allows selection in both the output box and the input box

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: pcwalton, Assigned: pcwalton)

Details

Attachments

(1 file, 1 obsolete file)

STR:
1. Open the Web Console.
2. Reload a page so that some messages appear in the console.
3. Enter text in the input box.
4. Select text from the output box.
5. Click in the output box.

Notice that the selection doesn't go away. I believe that this is due to the output node not being focusable (cf. Neil's comments in bug 592309).
Attached patch Proposed patch. (obsolete) — Splinter Review
Proposed patch attached.

Unfortunately, I had difficulty reproducing this in a unit test. Selecting the children of the node using window.getSelection().selectAllChildren(outputNode) and then simulating a click in the text field always works even without the patch, even though this is not what happens when the user clicks and drags. Suggestions/feedback welcome.
Assignee: nobody → pwalton
Status: NEW → ASSIGNED
Attachment #471658 - Flags: feedback?(ddahl)
Mistakenly uploaded an incorrect version of the patch. New patch attached.
Attachment #471658 - Attachment is obsolete: true
Attachment #471662 - Flags: feedback?(ddahl)
Attachment #471658 - Flags: feedback?(ddahl)
Whiteboard: [kd4b7]
I'm unable to reproduce this in a nightly...
Whiteboard: [kd4b7]
I think the re-skin fixed this. Closing WFM
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → WORKSFORME
Attachment #471662 - Flags: feedback?(ddahl)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: