Closed Bug 593447 Opened 14 years ago Closed 14 years ago

App tabs notify even if title is set but not changed

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: polidobj, Assigned: dao)

References

Details

Attachments

(2 files)

I see the notification of a title change when I use Yahoo Mail as an app Tab.  But the title hasn't changed.  (I still have zero new messages.)

To me it seems like Yahoo Mail always sets the title when it checks the server for new messages.  And even if the new title is the same as the old title the notification gets triggered.  

I'm attaching a testcase to prove that.  

1. Load it 
2. make it an App Tab
3. switch to another tab.

Expected:
No notification since the title is not changing.  It is being set to the same string.

Actual:
The App tab notifies that the title changed.  

I heard other things like Google Reader also does the same thing.
Nominating as a blocker, given that the original bug was a blocker, and the original bug as filed is not actually fixed (fixed as in doing what was intended originally - I understand that code was changed).
blocking2.0: --- → ?
Assignee: nobody → dao
Attached patch patchSplinter Review
Attachment #472139 - Flags: review?(gavin.sharp)
Comment on attachment 472139 [details] [diff] [review]
patch

You could change the setAttribute("crop") to use .crop.

Seems like ideally this would be done at a lower level (i.e. avoid firing DOMTitleChanged entirely in this case), but it's harder to evaluate the compatibility effects that could have. File a followup?
Attachment #472139 - Flags: review?(gavin.sharp) → review+
blocking2.0: ? → final+
OS: Windows XP → All
Hardware: x86 → All
(In reply to comment #3)
> Seems like ideally this would be done at a lower level (i.e. avoid firing
> DOMTitleChanged entirely in this case), but it's harder to evaluate the
> compatibility effects that could have.

I actually looked into this, but it seemed to me that title_window.xul depended on the current behavior. Now that I look at it again, maybe it doesn't.
http://hg.mozilla.org/mozilla-central/rev/72a4ec3eabf2
http://hg.mozilla.org/mozilla-central/rev/7dd97a6a7ff6

filed bug 593623
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b6
Depends on: 593626
Was this supposed to break notifications on gmail?  The title is updated each time a new email is received but now I'm not notified with the red glow.
(In reply to comment #6)
> Was this supposed to break notifications on gmail?  The title is updated each
> time a new email is received but now I'm not notified with the red glow.

I don't know what Gmail is exactly doing. Please file a new bug.
It's the same with yahoo mail.
Blocks: 593836
No longer depends on: 593626
Depends on: 594391
You need to log in before you can comment on or make changes to this bug.